Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Refactoring all graphapi related featurefile wording #7389

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented Sep 29, 2023

Description

This PR changes the text in the feature file so that they all look consistent. Noone of the test code is changed in the process.

How Has This Been Tested?

  • test environment:
  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@S-Panta S-Panta force-pushed the refactoring-all-graphapi-related-featurefile-wording branch 6 times, most recently from 678f388 to 5f95eaf Compare October 12, 2023 06:36
@S-Panta S-Panta marked this pull request as ready for review October 12, 2023 06:36
@S-Panta S-Panta force-pushed the refactoring-all-graphapi-related-featurefile-wording branch 3 times, most recently from b6a35b9 to 49b39f2 Compare October 13, 2023 08:40
@S-Panta S-Panta self-assigned this Oct 16, 2023
@S-Panta S-Panta force-pushed the refactoring-all-graphapi-related-featurefile-wording branch 4 times, most recently from 32598bf to 8a9bb52 Compare October 17, 2023 04:07
@SwikritiT
Copy link
Contributor

SwikritiT commented Oct 20, 2023

@S-Panta can please rebase and resolve conflicts if this is ready for review?

@S-Panta S-Panta force-pushed the refactoring-all-graphapi-related-featurefile-wording branch from 8a9bb52 to 62d3538 Compare October 20, 2023 09:14
@nabim777
Copy link
Member

nabim777 commented Oct 20, 2023

make line acceptance/features/apiSpaces/listSpaces.feature:84 into

When user "Alice" lists all available spaces via the Graph API with query "$filter=driveType eq 'personal'"

@S-Panta S-Panta force-pushed the refactoring-all-graphapi-related-featurefile-wording branch from 62d3538 to 0d7fd0f Compare October 30, 2023 03:38
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@S-Panta S-Panta force-pushed the refactoring-all-graphapi-related-featurefile-wording branch from 0d7fd0f to 584b323 Compare October 30, 2023 06:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SagarGi SagarGi requested a review from saw-jan October 30, 2023 08:38
@saw-jan saw-jan merged commit 1c66003 into master Oct 30, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the refactoring-all-graphapi-related-featurefile-wording branch October 30, 2023 12:12
ownclouders pushed a commit that referenced this pull request Oct 30, 2023
…rding (#7389)

* refactoring the feature file steps

* addressing review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants