Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Added tests with depth:infinity enabled #7395

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Oct 2, 2023

Description

Added test coverage for OCDAV_ALLOW_PROPFIND_DEPTH_INFINITY=true config option

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change. Other LGTM 👍

@saw-jan saw-jan force-pushed the tests/added-depth-infinity-tests branch from 2ad6d6a to ca85d99 Compare October 4, 2023 05:15
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

| dav-path | depth | http-code |
| /remote.php/dav/spaces/%spaceid% | 0 | 207 |
| /remote.php/dav/spaces/%spaceid% | 1 | 207 |
| /remote.php/dav/spaces/%spaceid% | infinity | 400 |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test cases for old/new dav paths will be added in this PR #7397

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit 0bf863b into master Oct 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the tests/added-depth-infinity-tests branch October 4, 2023 06:06
ownclouders pushed a commit that referenced this pull request Oct 4, 2023
* add depth infinity tests

* fix step

* add passing tests only

* format rable
saw-jan added a commit that referenced this pull request Oct 4, 2023
* add depth infinity tests

* fix step

* add passing tests only

* format rable
saw-jan added a commit that referenced this pull request Oct 5, 2023
* add depth infinity tests

* fix step

* add passing tests only

* format rable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make acceptance test run with OCDAV_ALLOW_PROPFIND_DEPTH_INFINITY default oCIS config value
3 participants