Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edit wrong named enves #7406

Merged
merged 7 commits into from
Oct 6, 2023
Merged

edit wrong named enves #7406

merged 7 commits into from
Oct 6, 2023

Conversation

case0sh
Copy link
Contributor

@case0sh case0sh commented Oct 4, 2023

Description

Checked and changed the envvars specified in the task and also removed those that are no longer used.

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Oct 4, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@case0sh case0sh requested a review from kobergj October 4, 2023 10:56
kobergj
kobergj requested changes Oct 4, 2023
View reviewed changes
services/auth-machine/pkg/config/config.go Outdated Show resolved Hide resolved
services/clientlog/pkg/config/debug.go Outdated Show resolved Hide resolved
services/storage-users/pkg/config/config.go Outdated Show resolved Hide resolved
services/storage-users/pkg/config/config.go Outdated Show resolved Hide resolved
services/webfinger/pkg/config/config.go Outdated Show resolved Hide resolved
@kobergj
Copy link
Collaborator

kobergj commented Oct 4, 2023

There are still occurrences of MachineAuthAPIKey in the idp service. That's why it doesn't build.

@case0sh case0sh force-pushed the wrong-envars branch 3 times, most recently from dfb77d6 to 41990be Compare October 5, 2023 13:12
@case0sh case0sh marked this pull request as ready for review October 5, 2023 13:16
@case0sh case0sh requested a review from kulmann as a code owner October 5, 2023 13:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kobergj kobergj merged commit 0984c8e into master Oct 6, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the wrong-envars branch October 6, 2023 12:41
ownclouders pushed a commit that referenced this pull request Oct 6, 2023
@kobergj
Merge pull request #7406 from owncloud/wrong-envars
1e0ea4a 
edit wrong named enves
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong named envvars
2 participants
@case0sh @kobergj