Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the default language added to the setting service #7417

Merged
merged 8 commits into from
Oct 9, 2023

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Oct 5, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment: Local.
  • Please fist read the notice in a readme!
  • test case 1: Set SETTINGS_DEFAULT_LANGUAGE=de, run ocis. Log in as admin, the UI language has to be DE. admin creates a file and shares it with einstein.
    Expected result:
  • If einstein did change a language in a setting to a language different from DE then einstein would receive a letter in DE.
  • If einstein already changed a language in a setting to language then einstein would receive a letter in selected language. But not all languages that we can see in a setting already exist for email notifications! If the language exits for UI but not exist for the email notifications then email notifications fail to EN.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Oct 5, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

services/settings/README.md Outdated Show resolved Hide resolved
2403905 and others added 2 commits October 5, 2023 17:22
Co-authored-by: Martin <github@diemattels.at>
Co-authored-by: Martin <github@diemattels.at>
services/settings/README.md Outdated Show resolved Hide resolved
@mmattel
Copy link
Contributor

mmattel commented Oct 5, 2023

What are the values that can be entered for a language and how to identify which languages are available?

@2403905
Copy link
Contributor Author

2403905 commented Oct 5, 2023

What are the values that can be entered for a language and how to identify which languages are available?

Good catch. I'll add

Co-authored-by: Martin <github@diemattels.at>
services/settings/README.md Outdated Show resolved Hide resolved
@mmattel
Copy link
Contributor

mmattel commented Oct 6, 2023

The value has the ISO 639-1 format ("de", "en", etc.) and is limited by the list supported languages.

Do we have a fallback if one sets an unsupported language to use the default?
If not, this must be implemented, if yes we should add this behaviour to readme.md.

@2403905 2403905 force-pushed the issue-e5915 branch 2 times, most recently from e6e0d15 to 0913b8a Compare October 6, 2023 15:09
Co-authored-by: Martin <github@diemattels.at>
@2403905 2403905 requested a review from kobergj October 6, 2023 15:34
@2403905 2403905 marked this pull request as ready for review October 6, 2023 15:38
services/settings/README.md Outdated Show resolved Hide resolved
@mmattel
Copy link
Contributor

mmattel commented Oct 9, 2023

Do we have a fallback if one sets an unsupported language to use the default?

I have to ask again, maybe I just cant read code properly, do we catch a language being set not being in the list of supported languages to fallback to the default language?

Co-authored-by: Martin <github@diemattels.at>
Co-authored-by: Martin <github@diemattels.at>
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a docs POV

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
5.2% 5.2% Duplication

@2403905 2403905 merged commit 7f6c832 into owncloud:master Oct 9, 2023
2 checks passed
ownclouders pushed a commit that referenced this pull request Oct 9, 2023
* the default language added to the setting service

Co-authored-by: Martin <github@diemattels.at>

---------

Co-authored-by: Roman Perekhod <rperekhod@owncloud.com>
Co-authored-by: Martin <github@diemattels.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants