-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the default language added to the setting service #7417
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Co-authored-by: Martin <github@diemattels.at>
Co-authored-by: Martin <github@diemattels.at>
What are the values that can be entered for a language and how to identify which languages are available? |
Good catch. I'll add |
Co-authored-by: Martin <github@diemattels.at>
Do we have a fallback if one sets an unsupported language to use the default? |
e6e0d15
to
0913b8a
Compare
Co-authored-by: Martin <github@diemattels.at>
I have to ask again, maybe I just cant read code properly, do we catch a language being set not being in the list of supported languages to fallback to the default language? |
Co-authored-by: Martin <github@diemattels.at>
Co-authored-by: Martin <github@diemattels.at>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a docs POV
Kudos, SonarCloud Quality Gate passed! |
* the default language added to the setting service Co-authored-by: Martin <github@diemattels.at> --------- Co-authored-by: Roman Perekhod <rperekhod@owncloud.com> Co-authored-by: Martin <github@diemattels.at>
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Expected result:
Screenshots (if appropriate):
Types of changes
Checklist: