Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix id or username query handling #745

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Fix id or username query handling #745

merged 1 commit into from
Oct 23, 2020

Conversation

butonic
Copy link
Member

@butonic butonic commented Oct 23, 2020

The code was stopping execution when encountering an error while loading an account by id. But for or queries we can continue execution.

@butonic butonic self-assigned this Oct 23, 2020
@butonic butonic added the bug label Oct 23, 2020
individual-it
individual-it approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sharing works again! 🕺

@individual-it
Copy link
Member

I would like to know how that could get through CI

@individual-it
Copy link
Member

tests pass
image

@butonic butonic force-pushed the fix-id-or-username-query-handling branch from 5465d18 to 6de314b Compare October 23, 2020 12:03
@butonic
Copy link
Member Author

butonic commented Oct 23, 2020

I don't get why the unit tests failed ... needed a rebase anyway ...

@butonic butonic force-pushed the fix-id-or-username-query-handling branch from 6de314b to 5c20f1c Compare October 23, 2020 12:04
@butonic
Fix id or username query handling
031a1b8 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the fix-id-or-username-query-handling branch from 5c20f1c to 031a1b8 Compare October 23, 2020 14:41
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit ea66c7d into owncloud:master Oct 23, 2020
@butonic butonic deleted the fix-id-or-username-query-handling branch October 23, 2020 15:58
ownclouders pushed a commit that referenced this pull request Oct 23, 2020
@phil-davis
commit ea66c7d
5281ec9 
Merge: 6e76b72 031a1b8
Author: Phil Davis <phil@jankaritech.com>
Date:   Fri Oct 23 21:29:49 2020 +0545

    Merge pull request #745 from butonic/fix-id-or-username-query-handling

    Fix id or username query handling
@micbar micbar mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@individual-it individual-it individual-it approved these changes

Assignees

@butonic butonic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@butonic @individual-it @kulmann @phil-davis