Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] added test for previewing shared resource inside project space #7544

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[tests-only][full-ci] added test for previewing shared resource inside project space #7544

merged 1 commit into from
Oct 26, 2023

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Oct 20, 2023 •
edited by grgprarup
Loading

Description

This PR adds test scenarios for previewing the shared resource inside of project space. Added scenarios:

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PrajwolAmatya PrajwolAmatya self-assigned this Oct 20, 2023
@PrajwolAmatya PrajwolAmatya mentioned this pull request Oct 20, 2023
Closed
3 tasks
@PrajwolAmatya PrajwolAmatya marked this pull request as ready for review October 20, 2023 08:22
SagarGi
SagarGi reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

tests/acceptance/features/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
@PrajwolAmatya PrajwolAmatya force-pushed the preview-spaces-shares branch 2 times, most recently from 3f12eba to bfc33fb Compare October 26, 2023 03:39
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@PrajwolAmatya PrajwolAmatya merged commit 2bee588 into master Oct 26, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the preview-spaces-shares branch October 26, 2023 07:14
ownclouders pushed a commit that referenced this pull request Oct 26, 2023
@PrajwolAmatya
added test for previewing shared resource inside project space (#7544)
78bed91
@PrajwolAmatya PrajwolAmatya mentioned this pull request Oct 26, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees

@PrajwolAmatya PrajwolAmatya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PrajwolAmatya @SagarGi @saw-jan