add file type filter chip

[2403905]

Description

Related Issue

• Issue [ocis] Add "File type" filter Chip #7432

Motivation and Context

How Has This Been Tested?

• test environment: local.
  The request example

curl --location --request REPORT 'https://:9200/remote.php/dav/spaces/admin/' \
--header 'Content-Type: application/xml' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data '<?xml version="1.0"?>
<oc:search-files  xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns">
    <d:prop>
        <oc:permissions />
        <oc:favorite />
        <oc:fileid />
        <oc:file-parent />
        <oc:name />
        <oc:owner-id />
        <oc:owner-display-name />
        <oc:shareid />
        <oc:shareroot />
        <oc:share-types />
        <oc:privatelink />
        <d:getcontentlength />
        <oc:size />
        <d:getlastmodified />
        <d:getetag />
        <d:getcontenttype />
        <d:resourcetype />
        <oc:downloadURL />
        <oc:tags />
    </d:prop>
    <oc:search>
        <oc:pattern>mimetype:pdf</oc:pattern>
        <oc:limit>8</oc:limit>
    </oc:search>
</oc:search-files>'

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[fschade]

the tests fail locally, let me know if i can help

[lookacat]

from testing it on web i can say it works perfect, just cant approve the PR because i think someone from the ocis team has more knowledge of the topic

[kobergj]

We are type asserting ln and rn multiple times here. Can't we solve that with a typeswitch? Like

right, ok := rn.(*bleveQuery.DisjunctionQuery)
switch left := ln.(type) {
default:
    if ok {
        left := bleveQuery.NewDisjunctionQuery([]bleveQuery.Query{ln})
        left.AddQuery(right.Disjuncts...)
        return left
    }
    fallthrough
case *bleveQuery.ConjunctionQuery:
    return bleveQuery.NewDisjunctionQuery([]bleveQuery.Query{ln, rn})
case *bleveQuery.DisjunctionQuery:
    if ok {
        left.AddQuery(right.Disjunkts)
    } else {
        left.AddQuery(rn)
   }
   return left	
}

Or similar. But we want to make the type assertions only once

[2403905]

The fallthrough doesn't work in this way.
I can rewrite but It became badly readable, sounds to me

		right, ok := rn.(*bleveQuery.DisjunctionQuery)
		switch left := ln.(type) {
		case *bleveQuery.DisjunctionQuery:
			if ok {
				left.AddQuery(right.Disjuncts...)
			} else {
				left.AddQuery(rn)
			}
			return left
		case *bleveQuery.ConjunctionQuery:
			return bleveQuery.NewDisjunctionQuery([]bleveQuery.Query{ln, rn})
		default:
			if ok {
				left := bleveQuery.NewDisjunctionQuery([]bleveQuery.Query{ln})
				left.AddQuery(right.Disjuncts...)
				return left
			} else {
				return bleveQuery.NewDisjunctionQuery([]bleveQuery.Query{ln, rn})
			}
		}

[kobergj]

Imo better readable than the double type assertion. If you ask me I'd go with second solution. But up to you in the end...

[kobergj]

You could skip the last else though 😉

[2403905]

reworked

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

53.5% Coverage
0.0% Duplication