Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce mtime keywords to the required ones #7919

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Dec 8, 2023

Description

As per product management requirements, this PR reduces the set of available mdate filter keywords, see owncloud/web#9779 (comment)

Related Issue

Motivation and Context

Keep filter options simple until we have more feedback what's actually needed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

update-docs bot commented Dec 8, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann
Copy link
Contributor Author

kulmann commented Dec 13, 2023

Need to adjust the e2e tests in the web repo... :-( there is one that uses the mdate search filter yesterday which I'm about to remove.

@kulmann kulmann force-pushed the reduce-mdate-filter-options branch from cfd156e to c21854b Compare December 21, 2023 18:49
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kulmann kulmann enabled auto-merge December 21, 2023 19:15
@kulmann kulmann disabled auto-merge December 21, 2023 19:35
@kulmann
Copy link
Contributor Author

kulmann commented Dec 21, 2023

The latest CI run had a failure in the binaries-darwin pipeline, pulling the owncloudci/nodejs image... everything else green. So I'll force merge.

@kulmann kulmann merged commit f882fbf into master Dec 21, 2023
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reduce-mdate-filter-options branch December 21, 2023 19:36
ownclouders pushed a commit that referenced this pull request Dec 21, 2023
fix: reduce mtime keywords to the required ones
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants