Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use copy of config instead of modifying the original configuration #808

Merged
merged 5 commits into from
Nov 11, 2020

Conversation

refs
Copy link
Member

@refs refs commented Nov 5, 2020

closes #672

We do this trick all over the place, it is because Micro needs to know beforehand which flags to parse, and they only need to be passed down.

@owncloud owncloud deleted a comment from update-docs bot Nov 6, 2020
@phil-davis
Copy link
Contributor

The tests could not create any accounts. I rebased just now to get up-to-date CI.

@phil-davis
Copy link
Contributor

I have restarted CI a couple of times. Test pipelines seem to fail a bit "randomly", e.g. https://drone.owncloud.com/owncloud/ocis/1249/20/7

When they fail, pretty much all the scenarios fail. They start getting an error like:

Provisioning::usersHaveBeenCreatedUnexpected failure when creating a user: HTTP status 400 HTTP reason Bad Request OCS status 400 OCS message account already exists (Exception)

And from there it's "all over". So some problem happens with deleting the account at the end of the previous scenario.

@refs
Copy link
Member Author

refs commented Nov 6, 2020

I have restarted CI a couple of times. Test pipelines seem to fail a bit "randomly", e.g. drone.owncloud.com/owncloud/ocis/1249/20/7

When they fail, pretty much all the scenarios fail. They start getting an error like:

Provisioning::usersHaveBeenCreatedUnexpected failure when creating a user: HTTP status 400 HTTP reason Bad Request OCS status 400 OCS message account already exists (Exception)

And from there it's "all over". So some problem happens with deleting the account at the end of the previous scenario.

Hmm I've seen that in some of my past PR's that the tests fail to delete the provided user, somehow. And what I saw in the past was that the service died and could not get more clients to the accounts service, but that doesn't seem to be the case here.

@refs
Copy link
Member Author

refs commented Nov 6, 2020

@phil-davis
Copy link
Contributor

I am also seeeing test pipelines like https://drone.owncloud.com/owncloud/ocis/1272/15/7 that get a long list of test fails. "something happens" (tm), users do not seem to be created and so everything fails. I suspect that something goes wrong in the accounts service or...

Re-running the drone CI of results in "mass failure" in some other pipeline. Or you get lucky and everything passes.

@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 7f1eef3 into master Nov 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-672 branch November 11, 2020 02:34
ownclouders pushed a commit that referenced this pull request Nov 11, 2020
Merge: 2ddc102 da25289
Author: Phil Davis <phil@jankaritech.com>
Date:   Wed Nov 11 08:19:39 2020 +0545

    Merge pull request #808 from owncloud/fix-672

    Use copy of config instead of modifying the original configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some env vars don't work
3 participants