Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide account.id in ocs api, use username #816

Merged
merged 1 commit into from
Nov 6, 2020
Merged

hide account.id in ocs api, use username #816

merged 1 commit into from
Nov 6, 2020

Conversation

butonic
Copy link
Member

@butonic butonic commented Nov 6, 2020 •
edited
Loading

the ocs should always expose the username. it is oblivious of our persistent account.id

  • changelog, for now I want to see if the tests break

@update-docs
Copy link

update-docs bot commented Nov 6, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic requested a review from kulmann November 6, 2020 16:15
@butonic butonic force-pushed the return-username-in-ocs-api branch from 156156b to c9b6dcf Compare November 6, 2020 16:32
@butonic
Copy link
Member Author

butonic commented Nov 6, 2020

@micbar does reusing changelog entries work?

@butonic
hide account.id in ocs api, use username
1456715 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the return-username-in-ocs-api branch from c9b6dcf to 1456715 Compare November 6, 2020 16:33
kulmann
kulmann approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@kulmann
Copy link
Contributor

kulmann commented Nov 6, 2020

@micbar does reusing changelog entries work?

Yes, as long as the changelog item you're adding to is unreleased. For already released ones a) it's not a good idea 😉 and b) will not be recognized by the docs bot. That only watches on unreleased items.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@butonic butonic merged commit 66fd583 into owncloud:master Nov 6, 2020
@butonic butonic deleted the return-username-in-ocs-api branch November 6, 2020 20:53
ownclouders pushed a commit that referenced this pull request Nov 6, 2020
@butonic
commit 66fd583
d65000a 
Merge: 1719862 1456715
Author: Jörn Friedrich Dreyer <jfd@butonic.de>
Date:   Fri Nov 6 21:53:35 2020 +0100

    Merge pull request #816 from butonic/return-username-in-ocs-api

    hide account.id in ocs api, use username
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@butonic @kulmann