Fix NatsRegistry #8281
Merged
Fix NatsRegistry #8281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <jkoberg@owncloud.com>
butonic
approved these changes
Jan 24, 2024
dragonchaser
approved these changes
Jan 24, 2024
| } | ||
|
|
||
| func getAuth() (string, string) { | ||
| return os.Getenv(_registryUsernameEnv), os.Getenv(_registryPasswordEnv) |
There was a problem hiding this comment.
Not a blocker but ugly. I am aware that it only works this way :/
|
rhafer
approved these changes
Jan 24, 2024
| Bugfix: Fix nats registry | ||
|
|
||
| The nats registry would behave badly when configuring `nats-js-kv` via envvar. Reason is the way go-micro initializes. | ||
| It took 5 developers to find the issue and the fix so the details cannot be shared here. Just accept that it is working now |
ownclouders
pushed a commit
that referenced
this pull request
Jan 24, 2024
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a rather strange issue with the natsjskv registry.
Thanks @butonic @rhafer @dragonchaser @fschade for the help in debugging this!