Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Add test to share resource inside of space #8327

Merged
merged 3 commits into from
Feb 1, 2024
Merged

[tests-only] Add test to share resource inside of space #8327

merged 3 commits into from
Feb 1, 2024

Conversation

grgprarup
Copy link
Contributor

Description

Added Scenarios:

  • Scenario Outline: send share invitation for resource of project space to user with different roles
  • Scenario Outline: send share invitation for resource of project space to group with different roles

Related Issue

How Has This Been Tested?

  • Locally
  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs Update Docs
Copy link

update-docs bot commented Jan 31, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@grgprarup grgprarup mentioned this pull request Jan 31, 2024
Closed
36 tasks
@grgprarup grgprarup self-assigned this Jan 31, 2024
@grgprarup grgprarup changed the title Add test to share resource inside of space [full-ci] [tests-only] Add test to share resource inside of space Feb 1, 2024
@grgprarup grgprarup force-pushed the add-test-to-share-resource-inside-of-space branch from 7c6f6eb to 5c3cd5a Compare February 1, 2024 09:35
@grgprarup grgprarup marked this pull request as ready for review February 1, 2024 09:35
saw-jan
saw-jan approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SagarGi
SagarGi approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM 👍

@grgprarup grgprarup changed the title [full-ci] [tests-only] Add test to share resource inside of space [tests-only] Add test to share resource inside of space Feb 1, 2024
@grgprarup grgprarup force-pushed the add-test-to-share-resource-inside-of-space branch from 5c3cd5a to 7134a47 Compare February 1, 2024 10:26
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit fbe1b42 into master Feb 1, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-test-to-share-resource-inside-of-space branch February 1, 2024 10:55
ownclouders pushed a commit that referenced this pull request Feb 1, 2024
@grgprarup
[tests-only] Add test to share resource inside of space (#8327)
83c7ab3 
* Added test to send share invitation with user for resource inside of project space

* Added test to send share invitation with group for resource inside of project space

* Addressed reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi approved these changes

@saw-jan saw-jan saw-jan approved these changes

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grgprarup @SagarGi @saw-jan