Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Add tests to list space files shared with user who is also member of group #8484

Merged
merged 1 commit into from
Feb 28, 2024
Merged

[tests-only][full-ci] Add tests to list space files shared with user who is also member of group #8484

merged 1 commit into from
Feb 28, 2024

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Feb 19, 2024 •
edited
Loading

Description

In this PR following scenarios are added related to sharingNG:

-   user who is also a member of group lists file shared with them from project-space
-   user who is also a member of group lists folder shared with them from project-space

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 marked this pull request as draft February 19, 2024 09:11
@nabim777 nabim777 force-pushed the tests/add-test-for-auto-accept-disable-with-user-group-in-project-space branch from 7be3fbf to d778f02 Compare February 19, 2024 09:18
@nabim777 nabim777 marked this pull request as ready for review February 19, 2024 09:33
@nabim777 nabim777 self-assigned this Feb 19, 2024
@nabim777 nabim777 requested a review from SagarGi February 19, 2024 09:33
@nabim777 nabim777 mentioned this pull request Feb 19, 2024
Closed
12 tasks
@nabim777 nabim777 force-pushed the tests/add-test-for-auto-accept-disable-with-user-group-in-project-space branch from d778f02 to 829fdbd Compare February 19, 2024 10:05
@nabim777 nabim777 force-pushed the tests/add-test-for-auto-accept-disable-with-user-group-in-project-space branch from 829fdbd to 2604cc2 Compare February 19, 2024 11:49
@nabim777 nabim777 requested a review from saw-jan February 19, 2024 11:51
@nabim777 nabim777 force-pushed the tests/add-test-for-auto-accept-disable-with-user-group-in-project-space branch 2 times, most recently from d123f16 to 8c31612 Compare February 20, 2024 07:28
@nabim777 nabim777 requested a review from SagarGi February 20, 2024 07:29
@nabim777 nabim777 force-pushed the tests/add-test-for-auto-accept-disable-with-user-group-in-project-space branch 3 times, most recently from ee46ed9 to 6f2a696 Compare February 20, 2024 11:15
grgprarup
grgprarup requested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase the PR, and follow the uniformity rule.

@nabim777 nabim777 force-pushed the tests/add-test-for-auto-accept-disable-with-user-group-in-project-space branch 4 times, most recently from 332d9aa to 949939d Compare February 21, 2024 04:55
@nabim777 nabim777 force-pushed the tests/add-test-for-auto-accept-disable-with-user-group-in-project-space branch from 3dbe4f9 to 4ab2592 Compare February 21, 2024 05:03
@nabim777 nabim777 requested a review from grgprarup February 21, 2024 05:21
@nabim777 nabim777 requested a review from grgprarup February 22, 2024 04:04
@nabim777 nabim777 force-pushed the tests/add-test-for-auto-accept-disable-with-user-group-in-project-space branch 2 times, most recently from e892fba to 8badce4 Compare February 22, 2024 07:34
@nabim777 nabim777 requested a review from saw-jan February 22, 2024 08:22
saw-jan
saw-jan reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabim777 Please, rebase the PR

@nabim777 nabim777 force-pushed the tests/add-test-for-auto-accept-disable-with-user-group-in-project-space branch from 8badce4 to 7baed14 Compare February 26, 2024 10:03
@nabim777 nabim777 requested a review from saw-jan February 26, 2024 10:12
@nabim777 nabim777 force-pushed the tests/add-test-for-auto-accept-disable-with-user-group-in-project-space branch 3 times, most recently from f43b163 to cd4b1ab Compare February 27, 2024 09:04
PrajwolAmatya
PrajwolAmatya approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

saw-jan
saw-jan reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can reduce some lines here

tests/acceptance/features/apiSharingNg/sharedWithMeSyncDisabled.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSharingNg/sharedWithMeSyncDisabled.feature Outdated Show resolved Hide resolved
@nabim777 nabim777 force-pushed the tests/add-test-for-auto-accept-disable-with-user-group-in-project-space branch 2 times, most recently from 9ac8dc9 to 71f85fe Compare February 27, 2024 10:18
@nabim777 nabim777 requested a review from saw-jan February 27, 2024 10:21
@nabim777 nabim777 force-pushed the tests/add-test-for-auto-accept-disable-with-user-group-in-project-space branch from 71f85fe to 3d8747e Compare February 28, 2024 04:13
@nabim777 nabim777 force-pushed the tests/add-test-for-auto-accept-disable-with-user-group-in-project-space branch from 3d8747e to 8cae159 Compare February 28, 2024 04:27
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 23eafeb into master Feb 28, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/add-test-for-auto-accept-disable-with-user-group-in-project-space branch February 28, 2024 08:19
ownclouders pushed a commit that referenced this pull request Feb 28, 2024
@nabim777
add tests to list space files shared with user who is member of group (…
5af8aeb 
…#8484)
rhafer pushed a commit to rhafer/ocis that referenced this pull request Mar 12, 2024
@nabim777 @rhafer
add tests to list space files shared with user who is member of group (…
f8d98a3 
…owncloud#8484)

(cherry picked from commit 23eafeb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrajwolAmatya PrajwolAmatya PrajwolAmatya approved these changes

@saw-jan saw-jan saw-jan approved these changes

@grgprarup grgprarup grgprarup approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@S-Panta S-Panta Awaiting requested review from S-Panta

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nabim777 @grgprarup @SagarGi @saw-jan @PrajwolAmatya