Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add image and photo metadata to search #8504

Merged
merged 5 commits into from
May 21, 2024
Merged

feat: add image and photo metadata to search #8504

merged 5 commits into from
May 21, 2024

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Feb 21, 2024 •
edited
Loading

Description

Add image and photo metadata to search.

Issues

Refs cs3org/reva#4684

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs Update Docs
Copy link

update-docs bot commented Feb 21, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann force-pushed the exif-metadata branch 2 times, most recently from 827b5e7 to 20c57a4 Compare February 22, 2024 05:55
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kulmann kulmann force-pushed the exif-metadata branch 2 times, most recently from 3246433 to ca4d280 Compare May 15, 2024 11:55
@kulmann kulmann mentioned this pull request May 15, 2024
Merged
7 tasks
@kulmann kulmann marked this pull request as ready for review May 15, 2024 13:12
@kulmann kulmann requested a review from dschmidt May 17, 2024 13:34
dschmidt
dschmidt approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, love it! 😍 🚀

services/idp/tsconfig.tsbuildinfo Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kulmann kulmann requested a review from butonic May 21, 2024 07:40
kobergj
kobergj approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kulmann kulmann merged commit 21a9992 into master May 21, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the exif-metadata branch May 21, 2024 08:21
ownclouders pushed a commit that referenced this pull request May 21, 2024
@kulmann
feat: add image and photo metadata to search (#8504)
7e8c5a3 
* feat: add image and photo metadata to search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@dschmidt dschmidt dschmidt approved these changes

@micbar micbar Awaiting requested review from micbar

@fschade fschade Awaiting requested review from fschade

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kulmann @dschmidt @kobergj