Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-only] ADR-0027 New share jail #8507

Merged
merged 1 commit into from
Mar 20, 2024
Merged

[docs-only] ADR-0027 New share jail #8507

merged 1 commit into from
Mar 20, 2024

Conversation

butonic
Copy link
Member

@butonic butonic commented Feb 21, 2024

As a follow up to #8420 @rhafer and I agreed to come up with an ADR that describes how to properly fix the oc:fileid in the sharejail.

cc @dragotin @micbar please comment or commit. I'll merge this on friday as draft, unless we all agree, then I'll set the status to accepted before merging.

@butonic butonic marked this pull request as ready for review February 21, 2024 16:40
@butonic butonic self-assigned this Feb 21, 2024
Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the unfinished sentence, this looks like a good summary of our discussion.

Would like to hear some more input from others, before changing the status to "accepted".

docs/ocis/adr/0027-new-share-jail.md Outdated Show resolved Hide resolved
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@butonic butonic merged commit 84a14c5 into master Mar 20, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the adr0027 branch March 20, 2024 15:23
ownclouders pushed a commit that referenced this pull request Mar 20, 2024
[docs-only] ADR-0027 New share jail
ownclouders pushed a commit that referenced this pull request Mar 21, 2024
[docs-only] ADR-0027 New share jail
ownclouders pushed a commit that referenced this pull request Mar 21, 2024
[docs-only] ADR-0027 New share jail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants