Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] check same name resources shared by different users #8630

Merged
merged 2 commits into from
Mar 21, 2024
Merged

[tests-only][full-ci] check same name resources shared by different users #8630

merged 2 commits into from
Mar 21, 2024

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Mar 13, 2024 •
edited
Loading

Description

This PR adds the tests to check the resource name when multiple users shares resource with the same name. We are basically checking if the suffix of the resource with the same name are correct or not.

Related Issue:

#8428
#8471

@SagarGi SagarGi self-assigned this Mar 13, 2024
@SagarGi SagarGi mentioned this pull request Mar 13, 2024
Open
34 tasks
@SagarGi SagarGi force-pushed the api-tests/suffix-inconsistent branch 2 times, most recently from 037b756 to 2fcc089 Compare March 13, 2024 07:09
@SagarGi
Copy link
Member Author

SagarGi commented Mar 13, 2024

This test fail will be resolved by this fix PRs #8543 cs3org/reva#4546. until then it is blocked.

@SagarGi SagarGi marked this pull request as ready for review March 13, 2024 07:12
@SagarGi SagarGi force-pushed the api-tests/suffix-inconsistent branch from 2fcc089 to 298a3c2 Compare March 19, 2024 03:45
@saw-jan saw-jan changed the title [tests-only][full-ci]list resources and check resource name with same name shared from dif… [tests-only][full-ci] check same name resources shared by different users Mar 19, 2024
@SagarGi
list resources and check resource name with same name shared from dif…
856be45 
…ferent users

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
@SagarGi SagarGi force-pushed the api-tests/suffix-inconsistent branch from 298a3c2 to d295940 Compare March 20, 2024 06:21
@SagarGi SagarGi requested a review from saw-jan March 20, 2024 06:22
@SagarGi SagarGi force-pushed the api-tests/suffix-inconsistent branch from d295940 to 921aa38 Compare March 21, 2024 04:16
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit ec8a4a0 into master Mar 21, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the api-tests/suffix-inconsistent branch March 21, 2024 06:20
ownclouders pushed a commit that referenced this pull request Mar 21, 2024
@SagarGi
[tests-only][full-ci] check same name resources shared by different u…
dac6e28 
…sers (#8630)

* list resources and check resource name with same name shared from different users

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>

* PR address

---------

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

@nabim777 nabim777 Awaiting requested review from nabim777

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SagarGi @saw-jan @nabim777