add permission check to role management #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
suggested changes
Nov 18, 2020
settings/pkg/service/v0/service.go
Outdated
| req.AccountUuid = getValidatedAccountUUID(c, req.AccountUuid) | ||
| func (g Service) AssignRoleToUser(ctx context.Context, req *proto.AssignRoleToUserRequest, res *proto.AssignRoleToUserResponse) error { | ||
| if !g.hasRoleManagementPermission(ctx) { | ||
| return merrors.BadRequest(g.id, "the user is not allowed to assign roles") |
There was a problem hiding this comment.
should return merrors.Forbidden
settings/pkg/service/v0/service.go
Outdated
| func (g Service) RemoveRoleFromUser(c context.Context, req *proto.RemoveRoleFromUserRequest, _ *empty.Empty) error { | ||
| func (g Service) RemoveRoleFromUser(ctx context.Context, req *proto.RemoveRoleFromUserRequest, _ *empty.Empty) error { | ||
| if !g.hasRoleManagementPermission(ctx) { | ||
| return merrors.BadRequest(g.id, "the user is not allowed to assign roles") |
There was a problem hiding this comment.
should return merrors.Forbidden
C0rby
force-pushed
the
check-role-management-permissions
branch
from
dec4657 to
2f69265
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
delete-merged-branch
bot
deleted the
check-role-management-permissions
branch
ownclouders
pushed a commit
that referenced
this pull request
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: add permission check when assigning and removing roles
Everyone could add and remove roles from users.
Added a new permission and a check so that only users with the role management permissions can assign and unassign roles.
Fixes #879