Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add maximum image dimension to be processed by the thumbnailer #9035

Merged
merged 2 commits into from
May 3, 2024

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Apr 30, 2024

Description

General hardening: limit input image size when processing thumbnails

TODO

  • test with different image formats - especially jpeg and geobra

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

update-docs bot commented Apr 30, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 marked this pull request as draft April 30, 2024 16:17
@DeepDiver1975 DeepDiver1975 force-pushed the fix/max-preview-dimensions branch from ef13944 to ad1741c Compare May 2, 2024 09:10
@DeepDiver1975 DeepDiver1975 marked this pull request as ready for review May 2, 2024 09:42
@DeepDiver1975 DeepDiver1975 force-pushed the fix/max-preview-dimensions branch 2 times, most recently from 7c1c896 to 82f7127 Compare May 2, 2024 13:55
Copy link
Contributor

@dragonchaser dragonchaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you are at it, could you please move the other errors to the errors package aswell?

services/thumbnails/pkg/thumbnail/thumbnail.go Outdated Show resolved Hide resolved
services/thumbnails/pkg/thumbnail/thumbnail_test.go Outdated Show resolved Hide resolved
@DeepDiver1975 DeepDiver1975 force-pushed the fix/max-preview-dimensions branch from 82f7127 to 8414e4c Compare May 2, 2024 14:56
@DeepDiver1975 DeepDiver1975 force-pushed the fix/max-preview-dimensions branch from 8414e4c to 5cdb49d Compare May 2, 2024 15:33
@DeepDiver1975 DeepDiver1975 force-pushed the fix/max-preview-dimensions branch from 5cdb49d to 6559857 Compare May 3, 2024 06:26
Copy link

sonarqubecloud bot commented May 3, 2024

@DeepDiver1975 DeepDiver1975 merged commit 9db3fd0 into master May 3, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/max-preview-dimensions branch May 3, 2024 10:20
ownclouders pushed a commit that referenced this pull request May 3, 2024
…9035)

* feat: add maximum image dimension to be processed by the thumbnailer

* chore: make golangci-lint happy
rhafer pushed a commit to rhafer/ocis that referenced this pull request Oct 9, 2024
…wncloud#9035)

* feat: add maximum image dimension to be processed by the thumbnailer

* chore: make golangci-lint happy

(cherry picked from commit 9db3fd0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants