Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ocis-web to 0.2.6 #935

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Update ocis-web to 0.2.6 #935

merged 2 commits into from
Nov 24, 2020

Conversation

LukasHirt
Copy link
Collaborator

No description provided.

@LukasHirt LukasHirt self-assigned this Nov 23, 2020
kulmann
kulmann requested changes Nov 23, 2020
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog is a bit off. maybe copy an already existing phoenix update changelog and just update the version and links

changelog/unreleased/add-eos copy.md Outdated Show resolved Hide resolved
changelog/unreleased/add-eos copy.md Outdated Show resolved Hide resolved
changelog/unreleased/add-eos copy.md Outdated Show resolved Hide resolved
@LukasHirt
Copy link
Collaborator Author

Dang it. Fixed the changelog.

@phil-davis
Copy link
Contributor

There are lots of UI test fails. The latest .drone.star in the Phoenix repo has some different environment variables...
e.g. owncloud/web@eb13615 sorted out a lot of environment variables for the OCIS server that runs during the Phoenix CI. But I see that some of the new/changed things there are actually not mentioned in .drone.star of OCIS. Maybe there is some env var magic that is needed here to get things working?

@kulmann
Copy link
Member

kulmann commented Nov 24, 2020 •
edited
Loading

There are lots of UI test fails. The latest .drone.star in the Phoenix repo has some different environment variables...
e.g. owncloud/phoenix@eb13615 sorted out a lot of environment variables for the OCIS server that runs during the Phoenix CI. But I see that some of the new/changed things there are actually not mentioned in .drone.star of OCIS. Maybe there is some env var magic that is needed here to get things working?

It looks like the assets were not generated correctly... I just pushed a commit with re-generated assets. Let's see what CI thinks about that before we spend time investigating env var changes.

@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kulmann
Copy link
Member

kulmann commented Nov 24, 2020

Web UI tests succeeded now. 👍 waiting for the remaining api tests..

@phil-davis
Copy link
Contributor

It's all green. Great stuff, merging.

@phil-davis phil-davis merged commit 09181cb into master Nov 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the update-phoenix-0.2.6 branch November 24, 2020 11:26
ownclouders pushed a commit that referenced this pull request Nov 24, 2020
@phil-davis
commit 09181cb
ff33ff2 
Merge: ee016ad 559f777
Author: Phil Davis <phil@jankaritech.com>
Date:   Tue Nov 24 17:10:56 2020 +0545

    Merge pull request #935 from owncloud/update-phoenix-0.2.6

    Update ocis-web to 0.2.6
@micbar micbar mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees

@LukasHirt LukasHirt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukasHirt @phil-davis @kulmann