Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] add test coverage for list permission for non-member user in project-space #9423

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Jun 20, 2024

Description

Here following test coverage scenario is added for the issue-9151

Scenario: non-member user tries to list the permissions of a project space using root endpoint

Also, there is added of issue tag which was removed in the PR https://github.com/owncloud/ocis/pull/9331/files

Related Issue

How Has This Been Tested?

  • test environment:
  • ci
  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Jun 20, 2024
@nabim777 nabim777 force-pushed the tests-coverage-project-space branch 2 times, most recently from 5cde10e to e8ccb45 Compare June 20, 2024 10:51
@nabim777 nabim777 changed the title [tests-only][full-ci] add test coverage for project-space [tests-only][full-ci] add test coverage for list permission for non-member user in project-space Jun 20, 2024


@issue-9151
Scenario: non-member user tries to list the permissions of a project space using permissions root endpoint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add test with permissions endpoint as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabim777 nabim777 force-pushed the tests-coverage-project-space branch from e8ccb45 to 8ee5355 Compare June 20, 2024 10:58
@nabim777 nabim777 force-pushed the tests-coverage-project-space branch from 8ee5355 to 1d0c0e2 Compare June 20, 2024 11:01
@nabim777 nabim777 requested a review from saw-jan June 20, 2024 11:02
Copy link

sonarcloud bot commented Jun 20, 2024

@saw-jan saw-jan merged commit f132f7f into master Jun 20, 2024
4 checks passed
@saw-jan saw-jan deleted the tests-coverage-project-space branch June 20, 2024 12:07
ownclouders pushed a commit that referenced this pull request Jun 20, 2024
[tests-only][full-ci] add test coverage for list permission for non-member user in project-space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants