-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC][tests-only] add endpoints to accept ocis commands #9546
Conversation
4399372
to
59d681d
Compare
59d681d
to
9de8d98
Compare
} catch (ConnectException $e) { | ||
throw new \Error("Cannot connect to the ociswrapper at the moment, make sure that ociswrapper is running before proceeding with the test run.\n" . $e->getMessage()); | ||
} catch (GuzzleException $ex) { | ||
$response = $ex->getResponse(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WHat will it throw if it's GuzzleException and response is not null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will not throw but returns the response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other looks good 👍
9de8d98
to
d8ab9c5
Compare
Quality Gate passedIssues Measures |
[POC][tests-only] add endpoints to accept ocis commands
Description
Added endpoints to run ocis command via API requests. These endpoints can be used by the test to run ocis commands.
Along with it, added CLI test for resetting user password.
Added endpoints:
/command
- run ocis command/start
- start ocis servercurl -XPOST "http://localhost:5200/start
/stop
- stop ocis servercurl -XPOST "http://localhost:5200/start
Added CLI test:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: