-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-only] docs: first draft of the custom apps in ocis and web blog post, part-1 #9601
base: master
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
53c1de4
to
fa5d50b
Compare
fa5d50b
to
b40e1c2
Compare
--- | ||
services: | ||
traefik: | ||
image: traefik:v2.9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example is outdated!!
Why not re-using the new one which is refactored and is on the latest stage?
You could create a hello
example based on ocis_full which would make imho much more sense.
See: https://github.com/owncloud/ocis/tree/master/deployments/examples/ocis_full
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, i will take care
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also traefik 2 is outdated, current is 3.1.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of 2024.10.24
, it is 3.1.6
@phil-davis I guess that a language review may be beneficial 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
English looks good. Looking forward to future parts that will give lots more detail about making web apps.
Co-authored-by: Martin <github@diemattels.at>
@mmattel many thanks for the text tunings, applied! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not love it more, thank you so much for writing it. I added a few nitpicks, but nevertheless it is awesome! ❤️
@dragotin can you check the latest graph, i think its more snappy now. |
Quality Gate passedIssues Measures |
@tbsbdr can you check and take over, i start writing part two now |
--- | ||
services: | ||
traefik: | ||
image: traefik:v2.9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also traefik 2 is outdated, current is 3.1.2
FYI, @micbar has added most of the |
it contains a good start for part 1, it needs some better writing here and there, should be enough as a starting point.
toDos:
@tbsbdr lets discuss the next steps