Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-only] docs: first draft of the custom apps in ocis and web blog post, part-1 #9601

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Jul 12, 2024

it contains a good start for part 1, it needs some better writing here and there, should be enough as a starting point.

toDos:

  • part-1: app basics, what it is, why you need it
    • basic article
    • text correction and better wording
  • part-2: write and ship a basic custom extension
    • basic article
    • text correction and better wording
    • docker app dev example and sandbox
  • part-3: advanced techniques and web-app sdk deep dive
    • basic article
    • text correction and better wording

@tbsbdr lets discuss the next steps

Copy link

update-docs bot commented Jul 12, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@fschade fschade force-pushed the writing-app-loading-blog-post branch from 53c1de4 to fa5d50b Compare July 12, 2024 16:56
@fschade fschade force-pushed the writing-app-loading-blog-post branch from fa5d50b to b40e1c2 Compare July 12, 2024 17:11
@fschade fschade changed the title docs: first draft of the custom apps in ocis and web blog post, part-1 [docs-only] docs: first draft of the custom apps in ocis and web blog post, part-1 Jul 13, 2024
---
services:
traefik:
image: traefik:v2.9.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example is outdated!!
Why not re-using the new one which is refactored and is on the latest stage?
You could create a hello example based on ocis_full which would make imho much more sense.
See: https://github.com/owncloud/ocis/tree/master/deployments/examples/ocis_full

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, i will take care

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also traefik 2 is outdated, current is 3.1.2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of 2024.10.24, it is 3.1.6

@mmattel mmattel requested a review from phil-davis July 15, 2024 07:49
@mmattel
Copy link
Contributor

mmattel commented Jul 15, 2024

@phil-davis I guess that a language review may be beneficial 😄

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English looks good. Looking forward to future parts that will give lots more detail about making web apps.

Co-authored-by: Martin <github@diemattels.at>
@fschade
Copy link
Contributor Author

fschade commented Jul 18, 2024

@mmattel many thanks for the text tunings, applied!

Copy link
Contributor

@dragotin dragotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not love it more, thank you so much for writing it. I added a few nitpicks, but nevertheless it is awesome! ❤️

docs/writings/web-apps/part-1.md Outdated Show resolved Hide resolved
docs/writings/web-apps/part-1.md Outdated Show resolved Hide resolved
docs/writings/web-apps/part-1.md Show resolved Hide resolved
@fschade
Copy link
Contributor Author

fschade commented Jul 24, 2024

@dragotin can you check the latest graph, i think its more snappy now.

Copy link

sonarcloud bot commented Jul 24, 2024

@fschade
Copy link
Contributor Author

fschade commented Jul 25, 2024

@tbsbdr can you check and take over, i start writing part two now

---
services:
traefik:
image: traefik:v2.9.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also traefik 2 is outdated, current is 3.1.2

@mmattel
Copy link
Contributor

mmattel commented Oct 24, 2024

FYI, @micbar has added most of the web-extensions to the ocis_full example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants