Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reva update v1.4.1-0.20201127111856-e6a6212c1b7b #971

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

refs
Copy link
Member

@refs refs commented Nov 27, 2020

@refs refs requested a review from kulmann November 27, 2020 11:37
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@phil-davis
Copy link
Contributor

phil-davis commented Nov 27, 2020

https://drone.owncloud.com/owncloud/ocis/1812/26/7

  Scenario Outline: Uploading file to a user read/write share folder works                                             # /srv/app/testrunner/tests/acceptance/features/apiShareOperationsToShares/uploadToShare.feature:95
    Given using <dav-path> DAV path                                                                                    # FeatureContext::usingOldOrNewDavPath()
    And user "Brian" has been created with default attributes and skeleton files                                       # FeatureContext::userHasBeenCreatedWithDefaultAttributes()
    And user "Alice" has created a share with settings                                                                 # FeatureContext::userHasCreatedAShareWithSettings()
      | path        | FOLDER |
      | shareType   | user   |
      | permissions | change |
      | shareWith   | Brian  |
    And user "Brian" has accepted share "/FOLDER" offered by user "Alice"                                              # FeatureContext::userHasReactedToShareOfferedBy()
    When user "Brian" uploads file "filesForUpload/textfile.txt" to "/Shares/FOLDER/textfile.txt" using the WebDAV API # FeatureContext::userUploadsAFileTo()
    Then the HTTP status code should be "201"                                                                          # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the content of file "/FOLDER/textfile.txt" for user "Alice" should be:                                         # FeatureContext::contentOfFileForUserShouldBePyString()
      """
      This is a testfile.
      
      Cheers.
      """

    Examples:
      | dav-path |
      | old      |
      | new      |
        The downloaded content was expected to be 'This is a testfile.
        
        Cheers.', but actually is ''. HTTP status was 500
        Failed asserting that two strings are equal.
        --- Expected
        +++ Actual
        @@ @@
        -'This is a testfile.\n
        -\n
        -Cheers.'
        +''

Hmmm - is that 500 status a new thing, or a "random" fail of something?

I restarted drone CI.

@refs
Copy link
Member Author

refs commented Nov 27, 2020

drone.owncloud.com/owncloud/ocis/1812/26/7

  Scenario Outline: Uploading file to a user read/write share folder works                                             # /srv/app/testrunner/tests/acceptance/features/apiShareOperationsToShares/uploadToShare.feature:95
    Given using <dav-path> DAV path                                                                                    # FeatureContext::usingOldOrNewDavPath()
    And user "Brian" has been created with default attributes and skeleton files                                       # FeatureContext::userHasBeenCreatedWithDefaultAttributes()
    And user "Alice" has created a share with settings                                                                 # FeatureContext::userHasCreatedAShareWithSettings()
      | path        | FOLDER |
      | shareType   | user   |
      | permissions | change |
      | shareWith   | Brian  |
    And user "Brian" has accepted share "/FOLDER" offered by user "Alice"                                              # FeatureContext::userHasReactedToShareOfferedBy()
    When user "Brian" uploads file "filesForUpload/textfile.txt" to "/Shares/FOLDER/textfile.txt" using the WebDAV API # FeatureContext::userUploadsAFileTo()
    Then the HTTP status code should be "201"                                                                          # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the content of file "/FOLDER/textfile.txt" for user "Alice" should be:                                         # FeatureContext::contentOfFileForUserShouldBePyString()
      """
      This is a testfile.
      
      Cheers.
      """

    Examples:
      | dav-path |
      | old      |
      | new      |
        The downloaded content was expected to be 'This is a testfile.
        
        Cheers.', but actually is ''. HTTP status was 500
        Failed asserting that two strings are equal.
        --- Expected
        +++ Actual
        @@ @@
        -'This is a testfile.\n
        -\n
        -Cheers.'
        +''

Hmmm - is that 500 status a new thing, or a "random" fail of something?

I restarted drone CI.

oh wow, weird, thanks for restarting

@sonarcloud
Copy link

sonarcloud bot commented Nov 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kulmann
Copy link
Member

kulmann commented Nov 27, 2020

https://drone.owncloud.com/owncloud/ocis/1812/26/7

  Scenario Outline: Uploading file to a user read/write share folder works                                             # /srv/app/testrunner/tests/acceptance/features/apiShareOperationsToShares/uploadToShare.feature:95
    Given using <dav-path> DAV path                                                                                    # FeatureContext::usingOldOrNewDavPath()
    And user "Brian" has been created with default attributes and skeleton files                                       # FeatureContext::userHasBeenCreatedWithDefaultAttributes()
    And user "Alice" has created a share with settings                                                                 # FeatureContext::userHasCreatedAShareWithSettings()
      | path        | FOLDER |
      | shareType   | user   |
      | permissions | change |
      | shareWith   | Brian  |
    And user "Brian" has accepted share "/FOLDER" offered by user "Alice"                                              # FeatureContext::userHasReactedToShareOfferedBy()
    When user "Brian" uploads file "filesForUpload/textfile.txt" to "/Shares/FOLDER/textfile.txt" using the WebDAV API # FeatureContext::userUploadsAFileTo()
    Then the HTTP status code should be "201"                                                                          # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the content of file "/FOLDER/textfile.txt" for user "Alice" should be:                                         # FeatureContext::contentOfFileForUserShouldBePyString()
      """
      This is a testfile.
      
      Cheers.
      """

    Examples:
      | dav-path |
      | old      |
      | new      |
        The downloaded content was expected to be 'This is a testfile.
        
        Cheers.', but actually is ''. HTTP status was 500
        Failed asserting that two strings are equal.
        --- Expected
        +++ Actual
        @@ @@
        -'This is a testfile.\n
        -\n
        -Cheers.'
        +''

Hmmm - is that 500 status a new thing, or a "random" fail of something?

I restarted drone CI.

It passed on the second run (and I restarted as well without paying close attention.. but passed there as well). So it seems to be a random failure @phil-davis

@refs refs merged commit d470d5c into master Nov 27, 2020
@refs refs deleted the reva-update-2020-11-27 branch November 27, 2020 12:33
ownclouders pushed a commit that referenced this pull request Nov 27, 2020
Merge: cda74f4 ca98d82
Author: Alex Unger <zyxancf@gmail.com>
Date:   Fri Nov 27 13:33:41 2020 +0100

    Merge pull request #971 from owncloud/reva-update-2020-11-27

    Reva update v1.4.1-0.20201127111856-e6a6212c1b7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants