Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit some lookups in gateway #9715

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Omit some lookups in gateway #9715

merged 2 commits into from
Jul 30, 2024

Conversation

butonic
Copy link
Member

@butonic butonic commented Jul 30, 2024

The CS3 gateway can directly to itself when it wants to talk to the registries running in the same reva runtime.

Requires a reva bump that is part of this PR to pull in cs3org/reva#4744

part of #8589

@butonic butonic requested a review from kobergj July 30, 2024 12:10
@butonic butonic self-assigned this Jul 30, 2024
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Protest with naming. Code looks good though 👍

services/gateway/pkg/revaconfig/config.go Outdated Show resolved Hide resolved
services/storage-system/pkg/revaconfig/config.go Outdated Show resolved Hide resolved
@butonic butonic requested a review from kobergj July 30, 2024 12:35
@butonic
Copy link
Member Author

butonic commented Jul 30, 2024

@kobergj mea culpa

Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@butonic butonic force-pushed the omit-some-lookups-in-gateway branch 2 times, most recently from ad97158 to 10764b4 Compare July 30, 2024 13:57
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

extract method

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the omit-some-lookups-in-gateway branch from 10764b4 to 297cc77 Compare July 30, 2024 14:14
@butonic butonic enabled auto-merge July 30, 2024 14:18
Copy link

sonarcloud bot commented Jul 30, 2024

@butonic butonic merged commit 89c5277 into master Jul 30, 2024
3 checks passed
ownclouders pushed a commit that referenced this pull request Jul 30, 2024
@butonic butonic deleted the omit-some-lookups-in-gateway branch August 2, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants