Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaboration openinapp refactor #9827

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Conversation

jvillafanez
Copy link
Member

Description

Simplify OpenInApp method. This contains:

  • Custom sublogger to compact log calls
  • Simplify and move the code to get the appURL
  • Move the code to generate the query params for the appURL

We've also temporarily removed the HostViewURL and HostEditURL for 2 reasons:

  • Current values are wrong. The values are expected to point to an ocis URL, not to Collabora (or other WOPI app)
  • It keeps the OpenInApp code simpler

Those values might can back with #9686

Related Issue

No opened issue

Motivation and Context

Code is simpler and easier to follow

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@jvillafanez jvillafanez self-assigned this Aug 16, 2024
Copy link

update-docs bot commented Aug 16, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jvillafanez jvillafanez force-pushed the collaboration_openinapp_refactor branch from b9842be to fe1712e Compare August 21, 2024 11:45
Copy link

@jvillafanez
Copy link
Member Author

Rebased. Minor changes to fix conflict in "services/collaboration/pkg/service/grpc/v0/service.go"

@butonic butonic merged commit ece0072 into master Aug 21, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Aug 21, 2024
@jvillafanez jvillafanez deleted the collaboration_openinapp_refactor branch August 21, 2024 15:01
ownclouders pushed a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants