Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] chore: bump web to v10.1.0 #9832

Merged
merged 3 commits into from
Aug 19, 2024
Merged

[full-ci] chore: bump web to v10.1.0 #9832

merged 3 commits into from
Aug 19, 2024

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Aug 16, 2024

As per title. See changelog item for changes.

Also enables the app store as default web app in web.

@JammingBen
Copy link
Contributor Author

@ScharfViktor @SagarGi CI is failing on this one, do you have an idea why? Did some lines of expected failures change?

@ScharfViktor
Copy link
Contributor

@ScharfViktor @SagarGi CI is failing on this one, do you have an idea why? Did some lines of expected failures change?

to fix e2e test tests/e2e/cucumber/features/oidc/refreshToken.feature:8
we need add extra envs to CI see here: https://github.com/owncloud/web/pull/11296/files#diff-6a968d4b7901c8526c8d9a86d1f434737dbfe2b00da21a7d3041ed4e3d58d62eR116-R128

@phil-davis
Copy link
Contributor

Note: owncloud/web#11366 has a small test code change to get it passing with the latest ocis master.
I suspect that that needs to be merged, and the web commit id for tests updated here, to get the web e2e tests to pass.

@ScharfViktor
Copy link
Contributor

regarding apiTest: we should change coreApiWebdavOperations/downloadFile.feature:231-261
I can adapt apiTest for new headers and add extra envs to CI to fix e2e test.

I'll do it

@ScharfViktor ScharfViktor mentioned this pull request Aug 19, 2024
21 tasks
@ScharfViktor
Copy link
Contributor

Note: owncloud/web#11366 has a small test code change to get it passing with the latest ocis master. I suspect that that needs to be merged, and the web commit id for tests updated here, to get the web e2e tests to pass.

these tests relate to app-provider suite which we don't run in ocis CI.

Copy link

sonarcloud bot commented Aug 19, 2024

@ScharfViktor ScharfViktor marked this pull request as ready for review August 19, 2024 08:46
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • CI is happy now
  • checked changelog ✅️

@JammingBen
Copy link
Contributor Author

Awesome, thanks for making CI green!

@JammingBen JammingBen merged commit 1ecff5e into master Aug 19, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Aug 19, 2024
[full-ci] chore: bump web to v10.1.0
@saw-jan saw-jan mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants