Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Test for activity filters #9861

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

Salipa-Gurung
Copy link
Contributor

@Salipa-Gurung Salipa-Gurung commented Aug 20, 2024

Description

Added test for depth:1 and limit:2 activity filter.

Related Issue

How Has This Been Tested?

  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@Salipa-Gurung Salipa-Gurung self-assigned this Aug 20, 2024
@Salipa-Gurung Salipa-Gurung force-pushed the test-activities-depth-filter branch 3 times, most recently from be70ae6 to d221ae0 Compare August 20, 2024 11:55
@Salipa-Gurung Salipa-Gurung force-pushed the test-activities-depth-filter branch 3 times, most recently from 51f397f to 235710c Compare August 22, 2024 07:03
@Salipa-Gurung Salipa-Gurung marked this pull request as ready for review August 22, 2024 07:07
tests/TestHelpers/GraphHelper.php Outdated Show resolved Hide resolved
tests/TestHelpers/GraphHelper.php Outdated Show resolved Hide resolved
@saw-jan saw-jan requested review from ishabaral, amrita-shrestha, PrajwolAmatya and nabim777 and removed request for nabim777 August 23, 2024 06:57
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM 👍

@Salipa-Gurung Salipa-Gurung force-pushed the test-activities-depth-filter branch 4 times, most recently from 4676d15 to 3d1757e Compare August 26, 2024 06:10
tests/TestHelpers/GraphHelper.php Outdated Show resolved Hide resolved
tests/acceptance/features/apiActivities/activities.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiActivities/activities.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiActivities/activities.feature Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/GraphContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/GraphContext.php Outdated Show resolved Hide resolved
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

sonarcloud bot commented Aug 26, 2024

@Salipa-Gurung Salipa-Gurung merged commit 83f80a5 into master Aug 26, 2024
4 checks passed
@Salipa-Gurung Salipa-Gurung deleted the test-activities-depth-filter branch August 26, 2024 10:29
ownclouders pushed a commit that referenced this pull request Aug 26, 2024
[tests-only] [full-ci] Test for activity filters
ownclouders pushed a commit that referenced this pull request Aug 27, 2024
[tests-only] [full-ci] Test for activity filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants