[tests-only][full-ci] test: add test coverage for opening file with non-existing fileId using /app/open-with-web endpoint #9985
Conversation
anon-pradip
force-pushed
the
test-non-existing-fileId
branch
from
09876a7
to
cecec9e
Compare
anon-pradip
requested review from
amrita-shrestha,
saw-jan,
ishabaral,
SagarGi,
prashant-gurung899,
Salipa-Gurung,
nabim777,
S-Panta,
PrajwolAmatya and
nirajacharya2
and removed request for
amrita-shrestha
| @@ -522,3 +522,33 @@ Feature: collaboration (wopi) | |||
| | app-endpoint | | |||
| | /app/open-with-web?file_id=<<FILEID>>&app_name=FakeOffice | | |||
| | /app/open-with-web?file_id=<<FILEID>> | | |||
|
|
|||
|
|
|||
| Scenario Outline: open file with non-existing file id (open-with-web) | |||
There was a problem hiding this comment.
this test is about sending post requests on deleted file rather than non existent. So either rewrite that here or use fake file id generate from function. Plus add tries to here too
There was a problem hiding this comment.
file-id of deleted file also doesn't exist in ocis.
There was a problem hiding this comment.
but how would you like to call the scenario should not matter in this case.
There was a problem hiding this comment.
file-id of deleted file also doesn't exist in ocis.
On the surface, it looks the same but in depth it's different. If the deleted file ID still works then how do we distinguish what the real problem is file id not deleted or random file ID giving a response
but how would you like to call the scenario should not matter in this case.
actually, it matter when we generalize scenarios title and then have to go through steps to understand the test case that consume lot of time
anon-pradip
force-pushed
the
test-non-existing-fileId
branch
2 times, most recently
from
c611945
to
5535ddb
Compare
anon-pradip
force-pushed
the
test-non-existing-fileId
branch
from
5535ddb
to
42dffaf
Compare
|
[tests-only][full-ci] test: add test coverage for opening file with non-existing fileId using /app/open-with-web endpoint
Description
Added test to send post request to /app/open-with-web endpoint with non-existing file id.
Related Issue
/app/endpoints #9682Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: