This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Remove click handler from th for sorting #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kulmann CI failes at unittests |
|
LGTM :) |
lookacat
approved these changes
Jul 26, 2021
|
Thanks @pascalwengerter for fixing the sorting tests! |
pascalwengerter
pushed a commit
that referenced
this pull request
Aug 5, 2021
Remove click handler from th for sorting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remaining fixes for fixing the table sorting for a11y. Click handler for sorting was firing double (once from the
<th>and once from the<oc-button>). Since the table heading is now in the button as well, we don't need the click handler on the<th>anymore.Fixes part (a) of owncloud/web#5380