Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Show path / parent folder to distinguish files #1860

Merged
merged 12 commits into from
Jan 10, 2022
Merged

Show path / parent folder to distinguish files #1860

merged 12 commits into from
Jan 10, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Jan 6, 2022 •
edited
Loading

Description

See owncloud/web#5953

Screenshots

favorites
search

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jan 6, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review January 7, 2022 12:15
@lookacat lookacat requested a review from fschade January 7, 2022 12:24
@lookacat lookacat force-pushed the feat-show-parent-folder-name branch from cb20300 to 0719e32 Compare January 7, 2022 12:39
fschade
fschade reviewed Jan 7, 2022
View reviewed changes
Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found some smaller issues

@lookacat lookacat requested a review from fschade January 8, 2022 10:51
fschade
fschade approved these changes Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one optional finding 👍

kulmann
kulmann reviewed Jan 10, 2022
View reviewed changes
src/components/organisms/OcResource/OcResource.vue Outdated
}

.text {
font-size: 13px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use a rem value

@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

5.9% 5.9% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit ea4ec3a into master Jan 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the feat-show-parent-folder-name branch January 10, 2022 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fschade fschade fschade approved these changes

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lookacat @kulmann @fschade