Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Redesign OcBreadcrumb #1975

Merged
merged 6 commits into from
Feb 24, 2022
Merged

Redesign OcBreadcrumb #1975

merged 6 commits into from
Feb 24, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Feb 23, 2022 •
edited
Loading

Description

See owncloud/web#6218

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

@update-docs
Copy link

update-docs bot commented Feb 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review February 23, 2022 12:49
pascalwengerter
pascalwengerter suggested changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing the locally built example with the example on owncloud.design shows some problems
First / Second / Third / Final gets turned into First > Second Third > Final which seems broken? Also, hover (background) colors don't seem to be respected

src/components/molecules/OcBreadcrumb/OcBreadcrumb.vue Show resolved Hide resolved
src/components/molecules/OcBreadcrumb/OcBreadcrumb.vue Outdated Show resolved Hide resolved
src/components/molecules/OcBreadcrumb/OcBreadcrumb.vue Show resolved Hide resolved
pascalwengerter
pascalwengerter suggested changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost... :)

src/components/molecules/OcBreadcrumb/OcBreadcrumb.vue Show resolved Hide resolved
src/components/molecules/OcBreadcrumb/OcBreadcrumb.vue Show resolved Hide resolved
src/components/molecules/OcBreadcrumb/OcBreadcrumb.vue Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

pascalwengerter
pascalwengerter approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash-on-merge

@lookacat lookacat merged commit 7d8ef69 into master Feb 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the redesign-breadcrumb branch February 24, 2022 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lookacat @pascalwengerter