Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

New icons for resource types #2005

Merged
merged 9 commits into from
Mar 14, 2022
Merged

New icons for resource types #2005

merged 9 commits into from
Mar 14, 2022

Conversation

elizavetaRa
Copy link
Member

@elizavetaRa elizavetaRa commented Mar 4, 2022 •
edited
Loading

Description

  • drawio
  • ifc
  • ipynb

@update-docs
Copy link

update-docs bot commented Mar 4, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@elizavetaRa
Copy link
Member Author

@tbsbdr @pascalwengerter @kulmann Guys, ping me if there are any other icons that are needed. We also have a jsroot icon, I don't know if it is needed upstream. And ping if some properties inside svg's need to be set in some other way.

@diocas
Copy link

diocas commented Mar 4, 2022

@elizavetaRa jupyter? def is more common than ifc

pascalwengerter
pascalwengerter suggested changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature branch would need a review, merge & rebase with changes in cernbox#222 included. Then I'm happy to proceed very quickly here :)

pascalwengerter and others added 3 commits March 7, 2022 15:16
@pascalwengerter
Add changelog & resource type/extension/color mapping, cleanup icon x…
a9c902e 
…ml (#222)

* Add changelog & resource type/extension/color mapping, cleanup icon xml

* Add ODG resource icon&color
@elizavetaRa
Update and rename enhancement-drawio-ifc-odg-icons to enhancement-dra…
18c48c0 
…wio-ifc-ipynb-odg-icons
@elizavetaRa
Update resourceIconExtensionMapping.json
0d1d62f
pascalwengerter
pascalwengerter suggested changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please omit the colors from the SVG, they will later be replaced by var(--oc-color-icon-ifc) according to the mapping we implemented (and make sure the color you desire is the right one in the color.yaml file)

src/assets/icons/resource-type-jupyter-fill.svg Outdated Show resolved Hide resolved
src/assets/icons/resource-type-jupyter-fill.svg Outdated Show resolved Hide resolved
elizavetaRa and others added 3 commits March 8, 2022 14:36
@elizavetaRa @pascalwengerter
Update src/assets/icons/resource-type-jupyter-fill.svg
7446b89 
Co-authored-by: Pascal Wengerter <pascal@wengerter.info>
@elizavetaRa @pascalwengerter
Update src/assets/icons/resource-type-jupyter-fill.svg
146e6f5 
Co-authored-by: Pascal Wengerter <pascal@wengerter.info>
@elizavetaRa
Update resourceIconColorExtensionMapping.json
8d8e9de
@elizavetaRa
Copy link
Member Author

Having a problem with ipynb icon. We want to use two colors there: standard file background color and orange for jupyter logo inside. I don't see how to set it as resourceIconExtensionMapping only maps one color, the background. I can of course cut out the logo instead of filling it but then it's not recognizable.

@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pascalwengerter pascalwengerter changed the base branch from master to icon-transition March 14, 2022 16:24
@pascalwengerter pascalwengerter merged commit 49abc3c into owncloud:icon-transition Mar 14, 2022
@pascalwengerter pascalwengerter mentioned this pull request Mar 14, 2022
Merged
pascalwengerter pushed a commit that referenced this pull request Mar 14, 2022
@elizavetaRa
New icons for resource types (#2005) (#2020)
4fa6716 
* New icons for resource types (#2005)

* drawio, ifc

* ipynb icon

* Add changelog & resource type/extension/color mapping, cleanup icon xml (#222)

* Add changelog & resource type/extension/color mapping, cleanup icon xml

* Add ODG resource icon&color

* Update and rename enhancement-drawio-ifc-odg-icons to enhancement-drawio-ifc-ipynb-odg-icons

* Update resourceIconExtensionMapping.json

* Update src/assets/icons/resource-type-jupyter-fill.svg

Co-authored-by: Pascal Wengerter <pascal@wengerter.info>

* Update src/assets/icons/resource-type-jupyter-fill.svg

Co-authored-by: Pascal Wengerter <pascal@wengerter.info>

* Update resourceIconColorExtensionMapping.json

* update: jupyter icon

Co-authored-by: Pascal Wengerter <pascal@wengerter.info>

* Add jupyter resource icon color token

* Change graphic resource-type icon

Co-authored-by: Elizaveta Ragozina <svillyfly@mail.ru>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pascalwengerter pascalwengerter pascalwengerter requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elizavetaRa @diocas @pascalwengerter