Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Small fixes #2036

Merged
merged 4 commits into from
Mar 21, 2022
Merged

Small fixes #2036

merged 4 commits into from
Mar 21, 2022

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Mar 21, 2022 •
edited
Loading

Description

@pascalwengerter pascalwengerter force-pushed the small-fixes branch 2 times, most recently from 9301304 to fd68952 Compare March 21, 2022 13:05
@pascalwengerter pascalwengerter changed the title WIP Make raw buttons respect button-related fontsizes Small fixes Mar 21, 2022
@pascalwengerter pascalwengerter marked this pull request as ready for review March 21, 2022 13:15
kulmann
kulmann suggested changes Mar 21, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results in huge raw buttons everywhere, which feels wrong. see screenshot.

Screenshot 2022-03-21 at 14 31 22

And in context menu it's like this (see "Open folder" vs the other actions):
Screenshot 2022-03-21 at 14 32 15

IMO we need to leave the raw buttons untouched. Side by side buttons of different appearances need to be avoided :-/

@pascalwengerter
Copy link
Contributor Author

IMO we need to leave the raw buttons untouched. Side by side buttons of different appearances need to be avoided :-/

Damn. So #1952 is the way to go here?

@kulmann
Copy link
Member

kulmann commented Mar 21, 2022

Damn. So #1952 is the way to go here?

yes, I think so

@pascalwengerter pascalwengerter force-pushed the small-fixes branch 2 times, most recently from f7fdb2a to e94ca38 Compare March 21, 2022 14:23
@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@pascalwengerter pascalwengerter merged commit e7e7114 into master Mar 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the small-fixes branch March 21, 2022 14:26
This was referenced Mar 21, 2022
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OcSelect] Background is not completely invisible
2 participants
@pascalwengerter @kulmann