Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Add OcCheckbox outline option, OcTable add event to TRow click #2218

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Add OcCheckbox outline option, OcTable add event to TRow click #2218

merged 5 commits into from
Jun 24, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Jun 23, 2022 •
edited
Loading

Description

See owncloud/web#6029

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

@update-docs
Copy link

update-docs bot commented Jun 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat mentioned this pull request Jun 23, 2022
Merged
9 tasks
@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lookacat lookacat marked this pull request as ready for review June 24, 2022 08:18
@lookacat lookacat requested a review from dschmidt June 24, 2022 08:19
JammingBen
JammingBen approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lookacat lookacat merged commit 24b7576 into master Jun 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the keyboard-navigation-selection branch June 24, 2022 09:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lookacat @dschmidt @JammingBen