Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Adjust share management to properly work with spaces #1013

Merged
merged 5 commits into from
Mar 3, 2022
Merged

Adjust share management to properly work with spaces #1013

merged 5 commits into from
Mar 3, 2022

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Feb 18, 2022 •
edited
Loading

This includes a new method shareSpaceWithUser as well as the possibility to pass URL params to the deleteShare method.

@JammingBen JammingBen self-assigned this Feb 18, 2022
@JammingBen JammingBen mentioned this pull request Feb 18, 2022
Merged
9 tasks
@JammingBen JammingBen marked this pull request as ready for review March 1, 2022 10:58
kulmann
kulmann suggested changes Mar 1, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shareFileWithUser and shareSpaceWithUser are very similar. Can you extract generic parts?

@JammingBen JammingBen requested a review from kulmann March 2, 2022 12:15
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit b52107a into master Mar 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the share-spaces branch March 3, 2022 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JammingBen @kulmann