Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of policy settings #41

Open
3 tasks
PVince81 opened this issue Jul 12, 2018 · 2 comments
Open
3 tasks

Validation of policy settings #41

PVince81 opened this issue Jul 12, 2018 · 2 comments
Labels
enhancement New feature or request p3-medium
Milestone

Comments

@PVince81
Copy link
Contributor

PVince81 commented Jul 12, 2018

@phil-davis @jvillafanez @pmaier1 for later

@PVince81 PVince81 added this to the backlog milestone Jul 12, 2018
@PVince81 PVince81 added the enhancement New feature or request label Jul 13, 2018
@PVince81 PVince81 changed the title Validation of expiration settings Validation of policy settings Jul 13, 2018
@PVince81
Copy link
Contributor Author

PVince81 commented Jul 13, 2018

  • disallow "0", empty string or negative values in any of the number fields

Note: on modern browsers the fields are treated as numbers, so this at least prevents to have negative values due to the "min" settings and also string values are prevented. Non-modern browsers might allow for it.

In general, the backend must validate these and refuse

@PVince81
Copy link
Contributor Author

From what I see most of the fields have "min='0'", need to check on a case by case basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p3-medium
Projects
None yet
Development

No branches or pull requests

1 participant