Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Password hint will be shown, even if the required length is set to 0 #344

Closed
AlexAndBear opened this issue Jul 5, 2021 · 2 comments · Fixed by #345
Closed

[QA] Password hint will be shown, even if the required length is set to 0 #344

AlexAndBear opened this issue Jul 5, 2021 · 2 comments · Fixed by #345
Assignees
Milestone

Comments

@AlexAndBear
Copy link

Steps to reproduce:

  1. Enable password min lowercase rule
  2. Set password min lowercase rule to 0

Actual behavior:

  • Hint shows At least 0 lower case letters

Expected: behavior:

  • Hint should not be displayed at all

image

@phil-davis
Copy link
Contributor

See #41 (comment)

Suggestion is to prevent entering the "0" setting. If a character type requirement is "enabled" then the number must be at least 1.

@AlexAndBear
Copy link
Author

AlexAndBear commented Jul 5, 2021

@phil-davis correct, I have set the min-value of html input to 1.
But this is indeed just working if you use the controls, you could easily enter a 0 char.
To come all over this, we need a backend validator, and this is too much for this particular issue.

AlexAndBear pushed a commit that referenced this issue Jul 5, 2021
Show only hints if numeric value is gt 0
@AlexAndBear AlexAndBear added this to the 2.1.3 milestone Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants