Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications of delete user are kept in oc_notifications table #53

Closed
davitol opened this issue Jul 13, 2018 · 5 comments
Closed

Notifications of delete user are kept in oc_notifications table #53

davitol opened this issue Jul 13, 2018 · 5 comments
Labels
bug Something isn't working p3-medium
Milestone

Comments

@davitol
Copy link
Contributor

davitol commented Jul 13, 2018

Steps to reproduce

  1. Login as admin
  2. Set Password policy about expiration of password with notification
  3. Create a new user and log in
  4. When the notification expiration time reaches, check oc_notifications table (a row with a notification for the user appears)
  5. As admin delete the user
  6. Run cronjob

Expected behavior

No log or reference to the notification of the deleted user should appear and the notifications related to the deleted user should be deleted

Current behavior

Notifications of the deleted user are kept in the oc_notifications table and a log is shown after running the cronjob. we should probably clean that table when deleting a user.

Content of oc_notifications;
6|password_policy|user1|1531480850|about_to_expire|8|about_to_expire|["1531480580",172800]|["1531480580",172800]|[{"label":"Change password","link":"http:\/\/localhost:9680\/index.php\/settings\/personal?sectionid=general","type":"GET","primary":false}]||about_to_expire|http://localhost:9680/index.php/settings/personal?sectionid=general
{"reqId":"dMNHVhEqUr1apF9zGUVi","level":2,"time":"2018-07-13T12:06:05+00:00","remoteAddr":"","user":"--","app":"notifications","method":"--","url":"--","message":"notification about_to_expire#12 can't be sent to user2 via email: the user is missing"}
@davitol davitol added the bug Something isn't working label Jul 13, 2018
@phil-davis
Copy link
Contributor

👍
and if someone works on this, then you probably want to also work on the other "left behind data" in the password history table #28

@PVince81
Copy link
Contributor

Mitigated through #56.

Will still need proper cleanup.

@PVince81
Copy link
Contributor

Estimate: 0.5md

@PVince81
Copy link
Contributor

put together in cleanup ticket: #69

@PVince81
Copy link
Contributor

PVince81 commented Aug 6, 2018

this is actually a core issue: owncloud/core#32243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p3-medium
Projects
None yet
Development

No branches or pull requests

3 participants