Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the user exists before sending the notification #56

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

jvillafanez
Copy link
Member

Related to #53

This should prevent the error message of the issue to appear.

@codecov-io
Copy link

codecov-io commented Jul 16, 2018

Codecov Report

Merging #56 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #56      +/-   ##
============================================
+ Coverage     71.67%   71.77%   +0.09%     
  Complexity      190      190              
============================================
  Files            25       25              
  Lines           872      875       +3     
============================================
+ Hits            625      628       +3     
  Misses          247      247
Impacted Files Coverage Δ Complexity Δ
lib/Jobs/PasswordExpirationNotifierJob.php 100% <100%> (ø) 9 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d7cbe...e8f14bc. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@PVince81 PVince81 added this to the development milestone Jul 16, 2018
@PVince81 PVince81 merged commit 4e2e765 into master Jul 16, 2018
@PVince81 PVince81 deleted the verify_user_exists branch July 16, 2018 07:35
@PVince81 PVince81 modified the milestones: development, qa Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants