Fix processing of multiple groups

[phil-davis]

Fixes scenarios of issue #143

1. The erroneous Invalid argument given. message is no longer shown when expiring passwords for a group.

2. When one of the group names is not a valid group, the command continues processing the remaining groups.

3. When one of the group names is not a valid group, the command continues processing the remaining groups.

At the end of processing, the totals of any missing groups or users are reported, and the command returns with non-zero status.

[phil-davis]

@PVince81 what should happen here?

Since we may have already processed some groups, I think we should continue on and process any other groups.

But then after looping through all the groups, should we remember that there was a problem with some group, and exit with non-zero status?

[PVince81]

yeah, sounds good. continue and report at the end

[PVince81]

fix now or create ticket for later for the additional reporting ?

[phil-davis]

@PVince81 please review.

This makes it try to process any mix of groups and UIDs given on the command line.
Each unknown group or UID is reported as it happens. The totals of unknown groups and UIDs are reported at the end.

[PVince81]

Makes sense. Next up would be updating the unit tests

[phil-davis]

Is there anyone who can do that quickly? I am not an expert in that area. And I should finish a couple of other password policy manual tests.

[phil-davis]

@sharidas or whoever does unit tests, it will need to test some of:

• multiple groups, some of which do not exist
• multiple UIDs, some of which do not exist
• multiple groups and UIDs in the one command
• multiple groups and UIDs in the one command, some of which do not exist

[codecov-io]

Codecov Report

Merging #144 into master will increase coverage by 0.56%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #144      +/-   ##
============================================
+ Coverage     72.26%   72.83%   +0.56%     
- Complexity      217      225       +8     
============================================
  Files            25       25              
  Lines           952      968      +16     
============================================
+ Hits            688      705      +17     
+ Misses          264      263       -1

Impacted Files	Coverage Δ	Complexity Δ
lib/Command/ExpirePassword.php	100% <100%> (+1.05%)	31 <0> (+8)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d9689d...a470435. Read the comment docs.