Validate expiration date for public links only

[VicDeo]

Depends on owncloud/core#37135
Fixes #287

TODO

• add an unit test to cover user/group/public link shares separately

[CLAassistant]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #293 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #293      +/-   ##
============================================
+ Coverage     73.52%   73.57%   +0.05%     
- Complexity      230      233       +3     
============================================
  Files            25       25              
  Lines           982      984       +2     
============================================
+ Hits            722      724       +2     
  Misses          260      260

Impacted Files	Coverage Δ	Complexity Δ
lib/HooksHandler.php	82.16% <100%> (+0.23%)	42 <0> (+3)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edb438f...18948be. Read the comment docs.

[phil-davis]

@VicDeo I pushed acceptance tests:

1. test scenarios that demonstrate the bug were done and merged in PR Add test scenarios to demonstrate issue-287 #294
2. adjustments to the test scenarios to test what is the really desired correct behaviour (those pass in this PR)

Please pull from GitHub, and add whatever unit tests you want. Then IMO we are done.

[VicDeo]

@phil-davis great, thanks!

[VicDeo]

@phil-davis unit tests have been updated

[phil-davis]

https://drone.owncloud.com/owncloud/password_policy/1210/43/10 acceptance tests fail because in drone CI the "current" daily-master-qa tarball is used as the core "server-under-test" and the current password_policy app code from this PR is used.

daily-master-qa tarball is now stale - the related/needed fix in core was only merged a few hours ago. We need someone to build a new daily-master-qa tarball, or wait until tomorrow.

[phil-davis]

I rebased just now, because #294 was merged.

We will need to restart CI again tomorrow after the core daily-master-qa tarball gets updated overnight.