Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See resource owner in share panel #2898

Closed
5 of 6 tasks
PVince81 opened this issue Jan 20, 2020 · 4 comments · Fixed by #2918
Closed
5 of 6 tasks

See resource owner in share panel #2898

PVince81 opened this issue Jan 20, 2020 · 4 comments · Fixed by #2918
Assignees
Labels
Category:Enhancement Add new functionality

Comments

@PVince81
Copy link
Contributor

PVince81 commented Jan 20, 2020

@PVince81 PVince81 added the Category:Enhancement Add new functionality label Jan 20, 2020
@PVince81 PVince81 self-assigned this Jan 20, 2020
@PVince81
Copy link
Contributor Author

PVince81 commented Jan 22, 2020

Direct share

image

Reshare

Logged in as Dave.
Received a reshare from Bob where the resource owner is Alice.
image

Indirect share through parent

Same as the "Reshare" scenario but showing indirect owner when inside a subdirectory.

image

Note: "via" icon will be changed to use the "redo" icon (forward arrow)

@pmaier1

@pmaier1
Copy link
Contributor

pmaier1 commented Jan 23, 2020

Very cool 👌 the "via" part in the third screenshot feels still a bit strange to me but maybe this is because of the strange folder name :)

@PVince81
Copy link
Contributor Author

yes, this is just a rough mock up to illustrate the idea.

we'll need to ellipsize the name

@PVince81
Copy link
Contributor Author

PVince81 commented Jan 24, 2020

@pmaier1 the proposed design above cannot work as there are scenarios where multiple resharers exist for the same resource:

  1. "alice" share "test" with user "bob"
  2. "alice" shares "test" with user "charlie"
  3. "bob" shares "test" with user "dave"
  4. "charlie" shares "test" with group "dave-group" (where dave is member).
  5. log in as "dave" and query the incoming shares for "test"

=> The API will deliver two incoming share entries:

  • shared with dave by bob (user share)
  • shared with dave by charlie (group share)

Our solution for this is to display owner and all reshares as separate collaborator entries:

  • Alice - Owner
  • Bob - Resharer
  • Charlie - Resharer

We need to keep in mind that the main use case is to find out who has access to the resource, so it's important to list all those people individually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants