Also show owner and resharer for indirect shares #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature
Show resolved
Hide resolved
individual-it
requested changes
Jan 28, 2020
PVince81
force-pushed
the
share-indirect-info-continued
branch
from
b2278fe
to
28dbb46
Compare
kulmann
approved these changes
Jan 28, 2020
|
Co-authored and co-reviewed with @kulmann. |
|
likely blocked by #2927 |
12 tasks
Co-authored-by: Vincent Petry <pvince81@owncloud.com> Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz> - Introduced npm dependency for path handling - Added via label above of owner and resharer for indirect shares - Refactor collaborator actions into the collaborator vue component. - Restyle collaborator list to use horizontal dividers. - Move content of collaborator list item from a grid into a table - Added test for via label - Added test for owner display in "shared with me" page - Refactored getCollaboratorsList to be able to return more detailed information
PVince81
force-pushed
the
share-indirect-info-continued
branch
from
28dbb46
to
239616f
Compare
|
Rebased to get the avatar fix. Conflict: had to integrate the Retested, still works. |
|
🎆 |
This was referenced Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display collaborator entries for indirect shares (inherited from parent resources) for owner and resharer.
Related Issue
Follow up of #2915
Fixes #2898
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks:
Use "redo" icon instead of anchorUse "exit to app"