Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon for flipping image #57

Merged
merged 1 commit into from
Aug 15, 2024
Merged

update icon for flipping image #57

merged 1 commit into from
Aug 15, 2024

Conversation

koebel
Copy link
Collaborator

@koebel koebel commented Aug 15, 2024

Description

In the scribbles for the dicom viewer app we had been using an icon for the flip image functionality that was not part of the remix icon set (the icon set didn't offer any icon for this purpose at that time). In the meanwhile the publishers of the remix icon set have added such an icon as suggested by us. In fact, they have even provided 2 variants (see Remix-Design/RemixIcon#650 (comment)). In this PR we have updated the icon to the one that was initially used in the scribbles.

Related Issue

Motivation and Context

make UI more intuitive by using suitable, less ambiguous icons

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added

Copy link

sonarcloud bot commented Aug 15, 2024

@koebel koebel mentioned this pull request Aug 15, 2024
13 tasks
@koebel koebel merged commit 749f281 into main Aug 15, 2024
2 checks passed
@koebel koebel deleted the change-icons-for-flip-image branch August 15, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants