Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add draw-io extension #10

Merged
merged 1 commit into from
Jul 22, 2024
Merged

feat: add draw-io extension #10

merged 1 commit into from
Jul 22, 2024

Conversation

JammingBen
Copy link
Contributor

Moves the draw-io extension from the Web repository to here since it has an external dependency and shouldn't be part of the default stack of Web apps.

refs owncloud/web#11248

packages/web-app-draw-io/src/App.vue Show resolved Hide resolved
@JammingBen JammingBen marked this pull request as ready for review July 22, 2024 12:08
@@ -0,0 +1,3 @@
# web-app-draw-io

This application can be used for creating, opening and editing `.draw` files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also lets you import some visio file type... not sure how good that works though.

@mmattel
Copy link
Contributor

mmattel commented Jul 22, 2024

Will draw-io drop out of the default delivery of ocis (web)?
We have made an announcement in the rolling release notes that is is part of.
In case, how to "install" it from an admins pov?

@tbsbdr fyi because we need to mention in upcoming release notes if that is gonna be changed

@kulmann
Copy link
Contributor

kulmann commented Jul 22, 2024

Will draw-io drop out of the default delivery of ocis (web)?

Yes. draw-io uses https://embed.diagrams.net internally. If you want to use draw-io you either need to accept that or deploy your own draw-io server. That's why I don't want to have it enabled by default...

This repo here will have a draw-io app release by the end of the week with a zip file attached. We have documentation in place in the dev docs what to do with that zip file. See https://github.com/owncloud/awesome-ocis

@JammingBen JammingBen dismissed DeepDiver1975’s stale review July 22, 2024 12:46

Has been clarified, nothing to change (for now)

@JammingBen JammingBen merged commit 63b5443 into main Jul 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants