Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add importer app #61

Merged
merged 1 commit into from
Oct 7, 2024
Merged

feat: add importer app #61

merged 1 commit into from
Oct 7, 2024

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen self-assigned this Oct 2, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 2, 2024

CLA assistant check
All committers have signed the CLA.

@mmattel

This comment has been minimized.

@AlexAndBear

This comment has been minimized.

@mmattel

This comment has been minimized.

@AlexAndBear

This comment has been minimized.

@mmattel

This comment has been minimized.

@AlexAndBear

This comment has been minimized.

@pascalwengerter
Copy link

@AlexAndBear we have some dev docs about this which is ok for devs, but we must have a description for admins in the admin docs. that is a different audience...

I generally agree but don't understand why this is a discussion that's happening in a pull request and not an issue opened in the relevant (docs) repository?

@kulmann
Copy link
Contributor

kulmann commented Oct 3, 2024

It's not documented in the admin docs because it's a very quickly moving topic and evolving fast. Documenting it twice (dev and admin) would just be what I call ABM (job-creation scheme). Having a simple link to the dev docs section and 1-2 sentences why it's not in the admin docs would be a good idea for the admin docs though.

@mmattel
Copy link
Contributor

mmattel commented Oct 3, 2024

We have to discuss this in more detail. I know things are moving fast, but I am looking forward to the coming stable release. Currently all stuff on dev docs is master and does therefore not hard align with versioned stuff like when we do a release. I am addressing this issue in particular.

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Oct 3, 2024

Not in this PR. I marked most of the conversation as off topic. @mmattel please open an issue in the docs repo and mark the relevant people you need input from.

@JammingBen JammingBen marked this pull request as ready for review October 7, 2024 08:37
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny idea for improvement about the dev stack integration... thanks for moving all that over from the web repo 😍

packages/web-app-importer/public/manifest.json Outdated Show resolved Hide resolved
@kulmann kulmann merged commit f5f051e into main Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants