Skip to content

Commit

Permalink
Disable more compat features
Browse files Browse the repository at this point in the history
  • Loading branch information
JammingBen committed Jan 20, 2023
1 parent cab8fc4 commit 236ca33
Show file tree
Hide file tree
Showing 6 changed files with 48 additions and 24 deletions.
4 changes: 2 additions & 2 deletions packages/design-system/src/components/OcButton/OcButton.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
v-bind="additionalAttributes"
:aria-label="ariaLabel"
:class="$_ocButton_buttonClass"
:disabled="disabled"
v-on="handlers"
>
<!-- @slot Content of the button -->
Expand Down Expand Up @@ -159,7 +158,8 @@ export default defineComponent({
...(this.href && { href: this.href }),
...(this.target && { target: this.target }),
...(this.to && { to: this.to }),
...(this.type === 'button' && { type: this.submit })
...(this.type === 'button' && { type: this.submit }),
...(this.type === 'button' && { disabled: this.disabled })
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/design-system/src/components/OcImage/OcImage.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<img :src="src" :alt="alt" :aria-hidden="!alt" :title="title" :loading="loadingType" />
<img :src="src" :alt="alt" :aria-hidden="`${!alt}`" :title="title" :loading="loadingType" />
</template>
<script lang="ts">
import { defineComponent } from 'vue'
Expand Down
24 changes: 24 additions & 0 deletions packages/design-system/src/components/OcSelect/OcSelect.vue
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,30 @@ export default defineComponent({
optionLabel: {
type: String,
default: null
},
/**
* Determines if the select field is searchable
*/
searchable: {
type: Boolean,
required: false,
default: false
},
/**
* Determines if the select field is clearable
*/
clearable: {
type: Boolean,
required: false,
default: false
},
/**
* Determines if the select field loading
*/
loading: {
type: Boolean,
required: false,
default: false
}
},
emits: ['search:input', 'update:modelValue'],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`MembersPanel should display an empty result if no matching members found 1`] = `
<div class="oc-ml-s">
<oc-text-input-stub class="oc-text-truncate oc-mr-s oc-mt-m" clearbuttonaccessiblelabel="" id="oc-textinput-3" label="Filter members" type="text" value="no-match"></oc-text-input-stub>
<oc-text-input-stub class="oc-text-truncate oc-mr-s oc-mt-m" clearbuttonaccessiblelabel="" id="oc-textinput-3" label="Filter members" modelvalue="no-match" type="text"></oc-text-input-stub>
<div>
<div>
<h3 class="oc-text-bold oc-text-medium">No members found</h3>
Expand All @@ -16,7 +16,7 @@ exports[`MembersPanel should display an empty result if no matching members foun

exports[`MembersPanel should render all members accordingly to their role assignments 1`] = `
<div class="oc-ml-s">
<oc-text-input-stub class="oc-text-truncate oc-mr-s oc-mt-m" clearbuttonaccessiblelabel="" id="oc-textinput-1" label="Filter members" type="text" value=""></oc-text-input-stub>
<oc-text-input-stub class="oc-text-truncate oc-mr-s oc-mt-m" clearbuttonaccessiblelabel="" id="oc-textinput-1" label="Filter members" modelvalue="" type="text"></oc-text-input-stub>
<div>
<!--v-if-->
<div class="oc-mb-m">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ exports[`DetailsAndEdit component if user can edit renders dropdown and edit but
</oc-button-stub>
</li>
<li class="oc-rounded oc-menu-item-hover">
<date-picker-stub class="link-expiry-picker oc-datepicker link-expiry-picker" inputdebounce="1000" locale="en" min-date="Wed Apr 01 2020 00:00:00 GMT+0000 (Coordinated Universal Time)" mode="date" modelconfig="[object Object]" popover="[object Object]" updateoninput="true">
<date-picker-stub class="oc-datepicker link-expiry-picker link-expiry-picker" inputdebounce="1000" locale="en" min-date="Wed Apr 01 2020 00:00:00 GMT+0000 (Coordinated Universal Time)" mode="date" modelconfig="[object Object]" popover="[object Object]" updateoninput="true">
<!-- @slot Default slot to use as the popover anchor for datepicker -->
<!-- args is undefined during initial render, hence we check it here -->
<!--v-if-->
Expand Down
36 changes: 18 additions & 18 deletions packages/web-runtime/src/compatConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,20 @@ import { configureCompat } from 'vue'

type CompatConfig = Parameters<typeof configureCompat>[0]
export const compatConfig: CompatConfig = {
MODE: 2,
// ATTR_ENUMERATED_COERCION: false,
MODE: 3,
ATTR_ENUMERATED_COERCION: false,
ATTR_FALSE_VALUE: 'suppress-warning',
// COMPONENT_ASYNC: false,
// COMPONENT_FUNCTIONAL: false,
// COMPONENT_V_MODEL: false,
// CONFIG_DEVTOOLS: false,
// CONFIG_IGNORED_ELEMENTS: false,
// CONFIG_KEY_CODES: false,
// CONFIG_OPTION_MERGE_STRATS: false,
// CONFIG_PRODUCTION_TIP: false,
// CONFIG_SILENT: false,
// CONFIG_WHITESPACE: false,
// CUSTOM_DIR: false,
COMPONENT_ASYNC: false,
COMPONENT_FUNCTIONAL: false,
COMPONENT_V_MODEL: false,
CONFIG_DEVTOOLS: false,
CONFIG_IGNORED_ELEMENTS: false,
CONFIG_KEY_CODES: false,
CONFIG_OPTION_MERGE_STRATS: false,
CONFIG_PRODUCTION_TIP: false,
CONFIG_SILENT: false,
CONFIG_WHITESPACE: 'suppress-warning',
CUSTOM_DIR: false,
FILTERS: false,
GLOBAL_DELETE: false,
GLOBAL_EXTEND: false,
Expand All @@ -31,18 +31,18 @@ export const compatConfig: CompatConfig = {
INSTANCE_DESTROY: false,
INSTANCE_EVENT_EMITTER: false,
INSTANCE_EVENT_HOOKS: false,
// INSTANCE_LISTENERS: false,
INSTANCE_LISTENERS: false,
INSTANCE_SCOPED_SLOTS: false,
INSTANCE_SET: false,
OPTIONS_BEFORE_DESTROY: false,
OPTIONS_DATA_FN: false,
OPTIONS_DATA_MERGE: false,
OPTIONS_DESTROYED: false,
// PRIVATE_APIS: false,
PRIVATE_APIS: false,
PROPS_DEFAULT_THIS: false,
RENDER_FUNCTION: false,
// TRANSITION_CLASSES: false,
// TRANSITION_GROUP_ROOT: false,
// V_ON_KEYCODE_MODIFIER: false,
TRANSITION_CLASSES: false,
TRANSITION_GROUP_ROOT: false,
V_ON_KEYCODE_MODIFIER: false,
WATCH_ARRAY: false
}

0 comments on commit 236ca33

Please sign in to comment.