refactor: rename open and sideBarOpen to isOpen and isSideBarOpen

packages/web-app-admin-settings/src/components/AppTemplate.vue

@@ -51,12 +51,12 @@
  <slot name="mainContent" />
  </div>
  <side-bar
- v-if="sideBarOpen"
+ v-if="isSideBarOpen"
  :active-panel="sideBarActivePanel"
  :available-panels="sideBarAvailablePanels"
  :panel-context="sideBarPanelContext"
  :loading="sideBarLoading"
- :open="sideBarOpen"
+ :is-open="isSideBarOpen"
  :is-header-compact="isSideBarHeaderCompact"
  @select-panel="selectPanel"
  @close="closeSideBar"
@@ -101,7 +101,7 @@ export default defineComponent({
  required: true,
  type: Array as PropType<BreadcrumbItem[]>
  },
- sideBarOpen: {
+ isSideBarOpen: {
  required: false,
  type: Boolean,
  default: false
@@ -165,7 +165,7 @@ export default defineComponent({
  const appBarRef = ref<VNodeRef>()
  const limitedScreenSpace = ref(false)
  const onResize = () => {
- limitedScreenSpace.value = props.sideBarOpen
+ limitedScreenSpace.value = props.isSideBarOpen
  ? window.innerWidth <= 1600
  : window.innerWidth <= 1200
  }
@@ -213,12 +213,12 @@ export default defineComponent({
  },
  computed: {
  toggleSidebarButtonLabel() {
- return this.sideBarOpen
+ return this.isSideBarOpen
  ? this.$gettext('Close sidebar to hide details')
  : this.$gettext('Open sidebar to view details')
  },
  toggleSidebarButtonIconFillType() {
- return this.sideBarOpen ? 'fill' : 'line'
+ return this.isSideBarOpen ? 'fill' : 'line'
  }
  }
 })

packages/web-app-admin-settings/src/views/Groups.vue

@@ -7,7 +7,7 @@
  :side-bar-active-panel="sideBarActivePanel"
  :side-bar-available-panels="sideBarAvailablePanels"
  :side-bar-panel-context="sideBarPanelContext"
- :side-bar-open="sideBarOpen"
+ :is-side-bar-open="isSideBarOpen"
  :show-batch-actions="!!selectedGroups.length"
  :batch-actions="batchActions"
  :batch-action-items="selectedGroups"

packages/web-app-admin-settings/src/views/Spaces.vue

@@ -7,7 +7,7 @@
  :side-bar-active-panel="sideBarActivePanel"
  :side-bar-available-panels="sideBarAvailablePanels"
  :side-bar-panel-context="sideBarPanelContext"
- :side-bar-open="sideBarOpen"
+ :is-side-bar-open="isSideBarOpen"
  :is-side-bar-header-compact="selectedSpaces.length === 1"
  :show-batch-actions="!!selectedSpaces.length"
  :batch-actions="batchActions"
@@ -41,7 +41,7 @@
  <div v-else>
  <SpacesList
  :spaces="spaces"
- :class="{ 'spaces-table-squashed': sideBarOpen }"
+ :class="{ 'spaces-table-squashed': isSideBarOpen }"
  :selected-spaces="selectedSpaces"
  @toggle-select-space="toggleSelectSpace"
  @select-spaces="selectSpaces"
@@ -113,7 +113,7 @@ export default defineComponent({
  const spaces = ref([])
  const clientService = useClientService()
  const { $gettext } = useGettext()
- const { sideBarOpen, sideBarActivePanel } = useSideBar()
+ const { isSideBarOpen, sideBarActivePanel } = useSideBar()
 
  const loadResourcesEventToken = ref(null)
  let updateQuotaForSpaceEventToken
@@ -281,7 +281,7 @@ export default defineComponent({
 
  return {
  maxQuota: useCapabilitySpacesMaxQuota(),
- sideBarOpen,
+ isSideBarOpen,
  sideBarActivePanel,
  spaces,
  loadResourcesTask,

packages/web-app-admin-settings/src/views/Users.vue

@@ -6,7 +6,7 @@
  :side-bar-active-panel="sideBarActivePanel"
  :side-bar-available-panels="sideBarAvailablePanels"
  :side-bar-panel-context="sideBarPanelContext"
- :side-bar-open="sideBarOpen"
+ :is-side-bar-open="isSideBarOpen"
  :side-bar-loading="sideBarLoading"
  :show-batch-actions="!!selectedUsers.length"
  :batch-actions="batchActions"
@@ -34,7 +34,7 @@
  <UsersList
  :users="users"
  :roles="roles"
- :class="{ 'users-table-squashed': sideBarOpen }"
+ :class="{ 'users-table-squashed': isSideBarOpen }"
  :selected-users="selectedUsers"
  @toggle-select-user="toggleSelectUser"
  @select-users="selectUsers"

packages/web-app-admin-settings/tests/unit/components/AppTemplate.spec.ts

@@ -58,11 +58,11 @@ describe('AppTemplate', () => {
  })
  describe('sideBar', () => {
  it('should show when opened', () => {
- const { wrapper } = getWrapper({ props: { sideBarOpen: true } })
+ const { wrapper } = getWrapper({ props: { isSideBarOpen: true } })
  expect(wrapper.find(stubSelectors.sideBar).exists()).toBeTruthy()
  })
  it('should not show when closed', () => {
- const { wrapper } = getWrapper({ props: { sideBarOpen: false } })
+ const { wrapper } = getWrapper({ props: { isSideBarOpen: false } })
  expect(wrapper.find(stubSelectors.sideBar).exists()).toBeFalsy()
  })
  it('can be toggled', async () => {
@@ -129,7 +129,7 @@ function getWrapper({ props = {}, isMobileWidth = false } = {}) {
  props: {
  loading: false,
  breadcrumbs: [],
- sideBarOpen: true,
+ isSideBarOpen: true,
  sideBarAvailablePanels: [],
  sideBarActivePanel: '',
  ...props

packages/web-app-admin-settings/tests/unit/views/__snapshots__/General.spec.ts.snap

@@ -2,6 +2,6 @@
 
 exports[`General view renders component 1`] = `
 <div>
- <app-template-stub batchactionitems="" batchactions="" breadcrumbs="[object Object],[object Object]" issidebarheadercompact="false" loading="false" showappbar="false" showbatchactions="false" showviewoptions="false" sidebaravailablepanels="" sidebarloading="false" sidebaropen="false"></app-template-stub>
+ <app-template-stub batchactionitems="" batchactions="" breadcrumbs="[object Object],[object Object]" issidebarheadercompact="false" loading="false" showappbar="false" showbatchactions="false" showviewoptions="false" sidebaravailablepanels="" sidebarloading="false" issidebaropen="false"></app-template-stub>
 </div>
 `;

packages/web-app-files/src/components/Search/List.vue

@@ -1,7 +1,11 @@
 <template>
  <div class="files-search-result oc-flex">
  <files-view-wrapper>
- <app-bar :breadcrumbs="breadcrumbs" :has-bulk-actions="true" :side-bar-open="sideBarOpen" />
+ <app-bar
+ :breadcrumbs="breadcrumbs"
+ :has-bulk-actions="true"
+ :is-side-bar-open="isSideBarOpen"
+ />
  <div v-if="displayFilter" class="files-search-result-filter oc-flex oc-mx-m oc-mb-m oc-mt-xs">
  <div class="oc-mr-m oc-flex oc-flex-middle">
  <oc-icon name="filter-2" class="oc-mr-xs" />
@@ -138,7 +142,7 @@
  </template>
  </files-view-wrapper>
  <file-side-bar
- :open="sideBarOpen"
+ :is-open="isSideBarOpen"
  :active-panel="sideBarActivePanel"
  :space="selectedResourceSpace"
  />

packages/web-app-files/src/components/Shares/SharedWithMeSection.vue

@@ -19,7 +19,7 @@
  v-model:selectedIds="selectedResourcesIds"
  :data-test-share-status="shareStatus"
  class="files-table"
- :class="{ 'files-table-squashed': sideBarOpen }"
+ :class="{ 'files-table-squashed': isSideBarOpen }"
  :fields-displayed="displayedFields"
  sidebar-closed
  :are-thumbnails-displayed="displayThumbnails"
@@ -171,7 +171,7 @@ export default defineComponent({
  type: Boolean,
  default: true
  },
- sideBarOpen: {
+ isSideBarOpen: {
  type: Boolean,
  default: false
  },

packages/web-app-files/src/components/Spaces/SpaceHeader.vue

@@ -1,7 +1,7 @@
 <template>
  <div
  class="space-header oc-p-m"
- :class="{ 'oc-flex': !imageExpanded && !isMobileWidth, 'space-header-squashed': sideBarOpen }"
+ :class="{ 'oc-flex': !imageExpanded && !isMobileWidth, 'space-header-squashed': isSideBarOpen }"
  >
  <div
  class="space-header-image"
@@ -106,7 +106,7 @@ export default defineComponent({
  type: Object as PropType<SpaceResource>,
  required: true
  },
- sideBarOpen: { type: Boolean, default: false }
+ isSideBarOpen: { type: Boolean, default: false }
  },
  setup(props) {
  const language = useGettext()

packages/web-app-files/src/composables/resourcesViewDefaults/useResourcesViewDefaults.ts

@@ -48,7 +48,7 @@ type ResourcesViewDefaultsResult<T, TT, TU extends any[]> = {
  selectedResourcesIds: Ref<(string | number)[]>
  isResourceInSelection(resource: Resource): boolean
 
- sideBarOpen: Ref<boolean>
+ isSideBarOpen: Ref<boolean>
  sideBarActivePanel: Ref<string>
 } & SelectedResourcesResult &
  ScrollToResult

packages/web-app-files/src/views/Favorites.vue

@@ -1,7 +1,7 @@
 <template>
  <div class="oc-flex">
  <files-view-wrapper>
- <app-bar :view-modes="viewModes" :side-bar-open="sideBarOpen" />
+ <app-bar :view-modes="viewModes" :is-side-bar-open="isSideBarOpen" />
  <app-loading-spinner v-if="areResourcesLoading" />
  <template v-else>
  <no-content-message
@@ -19,7 +19,7 @@
  id="files-favorites-table"
  v-model:selectedIds="selectedResourcesIds"
  class="files-table"
- :class="{ 'files-table-squashed': sideBarOpen }"
+ :class="{ 'files-table-squashed': isSideBarOpen }"
  :are-paths-displayed="true"
  :are-thumbnails-displayed="displayThumbnails"
  :resources="paginatedResources"
@@ -53,7 +53,7 @@
  </template>
  </files-view-wrapper>
  <file-side-bar
- :open="sideBarOpen"
+ :is-open="isSideBarOpen"
  :active-panel="sideBarActivePanel"
  :space="selectedResourceSpace"
  />

packages/web-app-files/src/views/shares/SharedViaLink.vue

@@ -1,7 +1,7 @@
 <template>
  <div class="oc-flex">
  <files-view-wrapper>
- <app-bar :side-bar-open="sideBarOpen">
+ <app-bar :is-side-bar-open="isSideBarOpen">
  <template #navigation>
  <SharesNavigation />
  </template>
@@ -23,7 +23,7 @@
  id="files-shared-via-link-table"
  v-model:selectedIds="selectedResourcesIds"
  class="files-table"
- :class="{ 'files-table-squashed': sideBarOpen }"
+ :class="{ 'files-table-squashed': isSideBarOpen }"
  :fields-displayed="['name', 'sharedWith', 'sdate']"
  :are-thumbnails-displayed="displayThumbnails"
  :are-paths-displayed="true"
@@ -56,7 +56,7 @@
  </template>
  </files-view-wrapper>
  <file-side-bar
- :open="sideBarOpen"
+ :is-open="isSideBarOpen"
  :active-panel="sideBarActivePanel"
  :space="selectedResourceSpace"
  />

packages/web-app-files/src/views/shares/SharedWithMe.vue

@@ -1,7 +1,7 @@
 <template>
  <div class="oc-flex">
  <files-view-wrapper class="oc-flex-column">
- <app-bar :has-bulk-actions="true" :side-bar-open="sideBarOpen">
+ <app-bar :has-bulk-actions="true" :is-side-bar-open="isSideBarOpen">
  <template #navigation>
  <SharesNavigation />
  </template>
@@ -72,7 +72,7 @@
  :display-thumbnails="displayThumbnails"
  :file-list-header-y="fileListHeaderY"
  :items="items"
- :side-bar-open="sideBarOpen"
+ :is-side-bar-open="isSideBarOpen"
  :sort-by="sortBy"
  :sort-dir="sortDir"
  :sort-handler="handleSort"
@@ -85,7 +85,7 @@
  </template>
  </files-view-wrapper>
  <file-side-bar
- :open="sideBarOpen"
+ :is-open="isSideBarOpen"
  :active-panel="sideBarActivePanel"
  :space="selectedShareSpace"
  />
@@ -97,7 +97,12 @@ import Fuse from 'fuse.js'
 import Mark from 'mark.js'
 import { useResourcesViewDefaults } from '../../composables'
 
-import { AppLoadingSpinner, FileSideBar, InlineFilterOption, ItemFilter } from '@ownclouders/web-pkg'
+import {
+ AppLoadingSpinner,
+ FileSideBar,
+ InlineFilterOption,
+ ItemFilter
+} from '@ownclouders/web-pkg'
 import { AppBar, ItemFilterInline } from '@ownclouders/web-pkg'
 import { queryItemAsString, useRouteQuery } from '@ownclouders/web-pkg'
 import SharedWithMeSection from '../../components/Shares/SharedWithMeSection.vue'
@@ -135,7 +140,7 @@ export default defineComponent({
  selectedResources,
  selectedResourcesIds,
  sideBarActivePanel,
- sideBarOpen,
+ isSideBarOpen,
  storeItems,
  scrollToResourceFromRoute
  } = useResourcesViewDefaults<Resource, any, any[]>()
@@ -260,7 +265,7 @@ export default defineComponent({
  selectedResources,
  selectedResourcesIds,
  fileListHeaderY,
- sideBarOpen,
+ isSideBarOpen,
  sideBarActivePanel,
  selectedShareSpace,
 

packages/web-app-files/src/views/shares/SharedWithOthers.vue

@@ -1,7 +1,7 @@
 <template>
  <div class="oc-flex">
  <files-view-wrapper>
- <app-bar :side-bar-open="sideBarOpen">
+ <app-bar :is-side-bar-open="isSideBarOpen">
  <template #navigation>
  <SharesNavigation />
  </template>
@@ -45,7 +45,7 @@
  id="files-shared-with-others-table"
  v-model:selectedIds="selectedResourcesIds"
  class="files-table"
- :class="{ 'files-table-squashed': sideBarOpen }"
+ :class="{ 'files-table-squashed': isSideBarOpen }"
  :fields-displayed="['name', 'sharedWith', 'sdate']"
  :are-thumbnails-displayed="displayThumbnails"
  :are-paths-displayed="true"
@@ -77,7 +77,7 @@
  </template>
  </files-view-wrapper>
  <file-side-bar
- :open="sideBarOpen"
+ :is-open="isSideBarOpen"
  :active-panel="sideBarActivePanel"
  :space="selectedResourceSpace"
  />

packages/web-app-files/src/views/spaces/GenericSpace.vue

@@ -9,7 +9,7 @@
  :show-actions-on-selection="displayFullAppBar"
  :has-sidebar-toggle="displayFullAppBar"
  :has-view-options="displayFullAppBar"
- :side-bar-open="sideBarOpen"
+ :is-side-bar-open="isSideBarOpen"
  :space="space"
  :view-modes="viewModes"
  @item-dropped="fileDropped"
@@ -48,7 +48,7 @@
  <space-header
  v-if="hasSpaceHeader"
  :space="space"
- :side-bar-open="sideBarOpen"
+ :is-side-bar-open="isSideBarOpen"
  class="oc-px-m oc-mt-m"
  />
  <no-content-message
@@ -107,7 +107,7 @@
  id="files-space-table"
  v-model:selectedIds="selectedResourcesIds"
  class="files-table"
- :class="{ 'files-table-squashed': sideBarOpen }"
+ :class="{ 'files-table-squashed': isSideBarOpen }"
  :view-mode="viewMode"
  :are-thumbnails-displayed="displayThumbnails"
  :resources="paginatedResources"
@@ -150,7 +150,7 @@
  </template>
  </template>
  </files-view-wrapper>
- <file-side-bar :open="sideBarOpen" :active-panel="sideBarActivePanel" :space="space" />
+ <file-side-bar :is-open="isSideBarOpen" :active-panel="sideBarActivePanel" :space="space" />
  </div>
 </template>