Adjust and add unit tests

owncloud · Mar 8, 2022 · 2c4f1ac · 2c4f1ac
1 parent f174a27
commit 2c4f1ac
Show file tree

Hide file tree

Showing 12 changed files with 292 additions and 103 deletions.
diff --git a/packages/web-app-files/tests/unit/components/AppBar/AppBar.spec.js b/packages/web-app-files/tests/unit/components/AppBar/AppBar.spec.js
@@ -206,7 +206,10 @@ function createStore(state = { selected: [], currentFolder: {} }, fileHandlers =
   return new Vuex.Store({
     getters: {
       getToken: jest.fn(),
-      quota: jest.fn()
+      quota: jest.fn(),
+      user: function () {
+        return { id: 'alice' }
+      }
     },
     modules: {
       Files: {

diff --git a/packages/web-app-files/tests/unit/components/FilesList/ContextActions.spec.js b/packages/web-app-files/tests/unit/components/FilesList/ContextActions.spec.js
@@ -201,6 +201,11 @@ function getWrapper(route, { filename, extension, type = '', mimeType }, availab
       $route: route,
       publicPage: () => false
     },
+    provide: {
+      currentSpace: {
+        value: {}
+      }
+    },
     propsData: {
       items: [
         {

diff --git a/packages/web-app-files/tests/unit/mixins/spaces/delete.spec.js b/packages/web-app-files/tests/unit/mixins/spaces/delete.spec.js
@@ -4,6 +4,7 @@ import { mount, createLocalVue } from '@vue/test-utils'
 import Delete from '@files/src/mixins/spaces/actions/delete.js'
 import { createLocationSpaces } from '../../../../src/router'
 import mockAxios from 'jest-mock-axios'
+import { buildSpace } from '../../../../src/helpers/resources'
 
 const localVue = createLocalVue()
 localVue.use(Vuex)
@@ -22,16 +23,42 @@ describe('delete', () => {
       expect(wrapper.vm.$_delete_items[0].isEnabled({ resources: [] })).toBe(false)
     })
     it('should be false when the space is not disabled', () => {
+      const spaceMock = {
+        id: '1',
+        root: {
+          permissions: [{ roles: ['manager'], grantedTo: [{ user: { id: 1 } }] }]
+        }
+      }
       const wrapper = getWrapper()
-      expect(
-        wrapper.vm.$_delete_items[0].isEnabled({ resources: [{ id: 1, disabled: false }] })
-      ).toBe(false)
+      expect(wrapper.vm.$_delete_items[0].isEnabled({ resources: [buildSpace(spaceMock)] })).toBe(
+        false
+      )
     })
     it('should be true when the space is disabled', () => {
+      const spaceMock = {
+        id: '1',
+        root: {
+          permissions: [{ roles: ['manager'], grantedTo: [{ user: { id: 1 } }] }],
+          deleted: { state: 'trashed' }
+        }
+      }
       const wrapper = getWrapper()
-      expect(
-        wrapper.vm.$_delete_items[0].isEnabled({ resources: [{ id: 1, disabled: true }] })
-      ).toBe(true)
+      expect(wrapper.vm.$_delete_items[0].isEnabled({ resources: [buildSpace(spaceMock)] })).toBe(
+        true
+      )
+    })
+    it('should be false when the current user is a viewer', () => {
+      const spaceMock = {
+        id: '1',
+        root: {
+          permissions: [{ roles: ['viewer'], grantedTo: [{ user: { id: 1 } }] }],
+          deleted: { state: 'trashed' }
+        }
+      }
+      const wrapper = getWrapper()
+      expect(wrapper.vm.$_delete_items[0].isEnabled({ resources: [buildSpace(spaceMock)] })).toBe(
+        false
+      )
     })
   })
 
@@ -105,6 +132,12 @@ function getWrapper() {
         getToken: () => 'token'
       },
       modules: {
+        user: {
+          state: {
+            id: 'alice',
+            uuid: 1
+          }
+        },
         Files: {
           namespaced: true,
           mutations: {

diff --git a/packages/web-app-files/tests/unit/mixins/spaces/disable.spec.js b/packages/web-app-files/tests/unit/mixins/spaces/disable.spec.js
@@ -4,6 +4,7 @@ import { mount, createLocalVue } from '@vue/test-utils'
 import disable from '@files/src/mixins/spaces/actions/disable.js'
 import { createLocationSpaces } from '../../../../src/router'
 import mockAxios from 'jest-mock-axios'
+import { buildSpace } from '../../../../src/helpers/resources'
 
 const localVue = createLocalVue()
 localVue.use(Vuex)
@@ -22,16 +23,41 @@ describe('disable', () => {
       expect(wrapper.vm.$_disable_items[0].isEnabled({ resources: [] })).toBe(false)
     })
     it('should be true when the space is not disabled', () => {
+      const spaceMock = {
+        id: '1',
+        root: {
+          permissions: [{ roles: ['manager'], grantedTo: [{ user: { id: 1 } }] }]
+        }
+      }
       const wrapper = getWrapper()
-      expect(
-        wrapper.vm.$_disable_items[0].isEnabled({ resources: [{ id: 1, disabled: false }] })
-      ).toBe(true)
+      expect(wrapper.vm.$_disable_items[0].isEnabled({ resources: [buildSpace(spaceMock)] })).toBe(
+        true
+      )
     })
     it('should be false when the space is disabled', () => {
+      const spaceMock = {
+        id: '1',
+        root: {
+          permissions: [{ roles: ['manager'], grantedTo: [{ user: { id: 1 } }] }],
+          deleted: { state: 'trashed' }
+        }
+      }
       const wrapper = getWrapper()
-      expect(
-        wrapper.vm.$_disable_items[0].isEnabled({ resources: [{ id: 1, disabled: true }] })
-      ).toBe(false)
+      expect(wrapper.vm.$_disable_items[0].isEnabled({ resources: [buildSpace(spaceMock)] })).toBe(
+        false
+      )
+    })
+    it('should be false when current user is a viewer', () => {
+      const spaceMock = {
+        id: '1',
+        root: {
+          permissions: [{ roles: ['viewer'], grantedTo: [{ user: { id: 1 } }] }]
+        }
+      }
+      const wrapper = getWrapper()
+      expect(wrapper.vm.$_disable_items[0].isEnabled({ resources: [buildSpace(spaceMock)] })).toBe(
+        false
+      )
     })
   })
 
@@ -106,6 +132,12 @@ function getWrapper() {
         getToken: () => 'token'
       },
       modules: {
+        user: {
+          state: {
+            id: 'alice',
+            uuid: 1
+          }
+        },
         Files: {
           namespaced: true,
           mutations: {

diff --git a/packages/web-app-files/tests/unit/mixins/spaces/editQuota.spec.js b/packages/web-app-files/tests/unit/mixins/spaces/editQuota.spec.js
@@ -1,6 +1,8 @@
 import Vuex from 'vuex'
 import { mount, createLocalVue } from '@vue/test-utils'
 import EditQuota from '@files/src/mixins/spaces/actions/editQuota.js'
+import { buildSpace } from '../../../../src/helpers/resources'
+import { createStore } from 'vuex-extensions'
 
 const localVue = createLocalVue()
 localVue.use(Vuex)
@@ -18,11 +20,47 @@ describe('editQuota', () => {
       const wrapper = getWrapper()
       expect(wrapper.vm.$_editQuota_items[0].isEnabled({ resources: [] })).toBe(false)
     })
+    it('should be true when the current user is a manager', () => {
+      const spaceMock = {
+        id: '1',
+        quota: {},
+        root: {
+          permissions: [{ roles: ['manager'], grantedTo: [{ user: { id: 1 } }] }]
+        }
+      }
+      const wrapper = getWrapper()
+      expect(
+        wrapper.vm.$_editQuota_items[0].isEnabled({ resources: [buildSpace(spaceMock)] })
+      ).toBe(true)
+    })
+    it('should be false when the current user is a viewer', () => {
+      const spaceMock = {
+        id: '1',
+        quota: {},
+        root: {
+          permissions: [{ roles: ['viewer'], grantedTo: [{ user: { id: 1 } }] }]
+        }
+      }
+      const wrapper = getWrapper()
+      expect(
+        wrapper.vm.$_editQuota_items[0].isEnabled({ resources: [buildSpace(spaceMock)] })
+      ).toBe(false)
+    })
   })
 })
 
 function getWrapper() {
   return mount(Component, {
-    localVue
+    localVue,
+    store: createStore(Vuex.Store, {
+      modules: {
+        user: {
+          state: {
+            id: 'alice',
+            uuid: 1
+          }
+        }
+      }
+    })
   })
 }
diff --git a/packages/web-app-files/tests/unit/mixins/spaces/editReadmeContent.spec.js b/packages/web-app-files/tests/unit/mixins/spaces/editReadmeContent.spec.js
@@ -1,6 +1,7 @@
 import Vuex from 'vuex'
 import { mount, createLocalVue } from '@vue/test-utils'
 import editReadmeContent from '@files/src/mixins/spaces/actions/editReadmeContent.js'
+import { buildSpace } from '../../../../src/helpers/resources'
 
 const localVue = createLocalVue()
 localVue.use(Vuex)
@@ -13,15 +14,47 @@ afterEach(() => jest.clearAllMocks())
 
 describe('editReadmeContent', () => {
   describe('isEnabled property', () => {
+    it('should be true for space managers', () => {
+      const spaceMock = {
+        id: '1',
+        root: { permissions: [{ roles: ['manager'], grantedTo: [{ user: { id: 1 } }] }] },
+        special: [{ specialFolder: { name: 'readme' } }]
+      }
+
+      const wrapper = getWrapper()
+      expect(
+        wrapper.vm.$_editReadmeContent_items[0].isEnabled({
+          resources: [buildSpace(spaceMock)]
+        })
+      ).toBe(true)
+    })
     it('should be false when not resource given', () => {
       const wrapper = getWrapper()
       expect(wrapper.vm.$_editReadmeContent_items[0].isEnabled({ resources: [] })).toBe(false)
     })
     it('should be false when spaceReadmeData does not exist', () => {
+      const spaceMock = {
+        id: '1',
+        root: { permissions: [{ roles: ['manager'], grantedTo: [{ user: { id: 1 } }] }] }
+      }
+
       const wrapper = getWrapper()
       expect(
         wrapper.vm.$_editReadmeContent_items[0].isEnabled({
-          resources: [{ id: 1 }]
+          resources: [buildSpace(spaceMock)]
+        })
+      ).toBe(false)
+    })
+    it('should be false when the current user is a viewer', () => {
+      const spaceMock = {
+        id: '1',
+        root: { permissions: [{ roles: ['viewer'], grantedTo: [{ user: { id: 1 } }] }] }
+      }
+
+      const wrapper = getWrapper()
+      expect(
+        wrapper.vm.$_editReadmeContent_items[0].isEnabled({
+          resources: [buildSpace(spaceMock)]
         })
       ).toBe(false)
     })
@@ -30,6 +63,16 @@ describe('editReadmeContent', () => {
 
 function getWrapper() {
   return mount(Component, {
-    localVue
+    localVue,
+    store: new Vuex.Store({
+      modules: {
+        user: {
+          state: {
+            id: 'alice',
+            uuid: 1
+          }
+        }
+      }
+    })
   })
 }
diff --git a/packages/web-app-files/tests/unit/mixins/spaces/restore.spec.js b/packages/web-app-files/tests/unit/mixins/spaces/restore.spec.js
@@ -4,6 +4,7 @@ import { mount, createLocalVue } from '@vue/test-utils'
 import restore from '@files/src/mixins/spaces/actions/restore.js'
 import { createLocationSpaces } from '../../../../src/router'
 import mockAxios from 'jest-mock-axios'
+import { buildSpace } from '../../../../src/helpers/resources'
 
 const localVue = createLocalVue()
 localVue.use(Vuex)
@@ -22,16 +23,42 @@ describe('restore', () => {
       expect(wrapper.vm.$_restore_items[0].isEnabled({ resources: [] })).toBe(false)
     })
     it('should be false when the space is not disabled', () => {
+      const spaceMock = {
+        id: '1',
+        root: {
+          permissions: [{ roles: ['manager'], grantedTo: [{ user: { id: 1 } }] }]
+        }
+      }
       const wrapper = getWrapper()
-      expect(
-        wrapper.vm.$_restore_items[0].isEnabled({ resources: [{ id: 1, disabled: false }] })
-      ).toBe(false)
+      expect(wrapper.vm.$_restore_items[0].isEnabled({ resources: [buildSpace(spaceMock)] })).toBe(
+        false
+      )
     })
     it('should be true when the space is disabled', () => {
+      const spaceMock = {
+        id: '1',
+        root: {
+          permissions: [{ roles: ['manager'], grantedTo: [{ user: { id: 1 } }] }],
+          deleted: { state: 'trashed' }
+        }
+      }
       const wrapper = getWrapper()
-      expect(
-        wrapper.vm.$_restore_items[0].isEnabled({ resources: [{ id: 1, disabled: true }] })
-      ).toBe(true)
+      expect(wrapper.vm.$_restore_items[0].isEnabled({ resources: [buildSpace(spaceMock)] })).toBe(
+        true
+      )
+    })
+    it('should be false when the current user is a viewer', () => {
+      const spaceMock = {
+        id: '1',
+        root: {
+          permissions: [{ roles: ['viewer'], grantedTo: [{ user: { id: 1 } }] }],
+          deleted: { state: 'trashed' }
+        }
+      }
+      const wrapper = getWrapper()
+      expect(wrapper.vm.$_restore_items[0].isEnabled({ resources: [buildSpace(spaceMock)] })).toBe(
+        false
+      )
     })
   })
 
@@ -106,6 +133,12 @@ function getWrapper() {
         getToken: () => 'token'
       },
       modules: {
+        user: {
+          state: {
+            id: 'alice',
+            uuid: 1
+          }
+        },
         Files: {
           namespaced: true,
           mutations: {