Merge pull request #2808 from owncloud/remove-unnecessary-await

Remove unnecessary async-await
owncloud · Jan 3, 2020 · 68acdbf · 68acdbf
2 parents 732eba8 + a3ae63c
commit 68acdbf
Show file tree

Hide file tree

Showing 7 changed files with 53 additions and 52 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -13,6 +13,7 @@
         "sourceType": "module"
     },
     "rules": {
+      "require-await": "warn"
     },
     "globals": {
       "require": false,

diff --git a/apps/files/src/components/Trashbin.vue b/apps/files/src/components/Trashbin.vue
@@ -168,7 +168,7 @@ export default {
 
       const self = this
       function deleteFile (file) {
-        return async () => {
+        return () => {
           return self.$client.fileTrash.clearTrashBin(file.id)
             .then(() => {
               self.$_ocTrashbin_removeFileFromList([file])

diff --git a/tests/acceptance/helpers/filesFoldersHelper.js b/tests/acceptance/helpers/filesFoldersHelper.js
@@ -33,7 +33,7 @@ exports.getAllFiles = async function (user) {
   return filenames.filter(elements => !elements.endsWith('/'))
 }
 
-exports.getElementsMatchingPattern = async function (pattern, files) {
+exports.getElementsMatchingPattern = function (pattern, files) {
   return files.filter(elements => elements.toLowerCase().includes(pattern))
 }
 

diff --git a/tests/acceptance/pageObjects/FilesPageElement/filesList.js b/tests/acceptance/pageObjects/FilesPageElement/filesList.js
@@ -633,7 +633,7 @@ module.exports = {
      * @returns {Promise.<[]>} Array of files/folders element
      */
     allFileRows: async function () {
-      this
+      await this
         .waitForElementNotPresent('@filesListProgressBar')
         .waitForElementVisible({
           selector: '@fileRows',

diff --git a/tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js b/tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js
@@ -373,7 +373,7 @@ module.exports = {
      *
      * @returns {Promise.<string[]>} Array of autocomplete webElementIds
      */
-    deleteShareWithUserGroup: async function (item) {
+    deleteShareWithUserGroup: function (item) {
       const informationSelector = util.format(this.elements.collaboratorInformationByCollaboratorName.selector, item)
       const deleteSelector = informationSelector + this.elements.deleteShareButton.selector
       return this

diff --git a/tests/acceptance/pageObjects/phoenixPage.js b/tests/acceptance/pageObjects/phoenixPage.js
@@ -55,7 +55,7 @@ module.exports = {
         .click('@messageCloseIcon')
         .waitForElementNotPresent('@messageCloseIcon')
     },
-    toggleNotificationDrawer: async function () {
+    toggleNotificationDrawer: function () {
       return this.waitForElementVisible('@notificationBell').click('@notificationBell')
     },
     /**

diff --git a/tests/acceptance/stepDefinitions/filesContext.js b/tests/acceptance/stepDefinitions/filesContext.js